Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request getter casting #13

Open
emulgeator opened this issue May 24, 2015 · 1 comment
Open

Request getter casting #13

emulgeator opened this issue May 24, 2015 · 1 comment
Milestone

Comments

@emulgeator
Copy link
Collaborator

Right now we are casting every request parameter to its required type in the controller (or where we are using it). This should be moved into the framework, so we can have the casting in one place.
Also we can avoid the "Array to string conversion" notices by checking these special cases.
Beside the casting we should also do some validation for character encoding, as it happens day to day that a f@!$d up browser sends invalid UTF-8 sequence which can lead to strange errors such as warning from json_encode. Please read the "Character Validation" topic here: http://webcollab.sourceforge.net/unicode.html

@emulgeator emulgeator modified the milestone: v0.4.0 May 25, 2015
@emulgeator
Copy link
Collaborator Author

Another thing that it would make sense to automatically trim the request params by default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant