Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broader minor changes #11

Open
bjendres opened this issue Dec 6, 2024 · 1 comment
Open

Broader minor changes #11

bjendres opened this issue Dec 6, 2024 · 1 comment

Comments

@bjendres
Copy link
Member

bjendres commented Dec 6, 2024

  1. Let's take the chance for reformatting the affected files according to CiviCRM code style, see Add code quality tools and configuration (PHP Code Sniffer, PHPStan, PHPUnit) #10 for introducing code quality tools. (see Add change processing #9)
  2. Rename Message class, e.g. to ShareMessage? -see Add change processing #9 / HERE - see Add change processing #9
  3. Let's name the variable $changeProcessingEvent or just $event -see Add change processing #9
  4. Let's define the event name in a constant - see Add change processing #9
  5. Let's use OOP style for executing API4 actions. - see Add change processing #9
  6. Let's rename $peered_node to $peering, as it is not holding the node itself. - see Add change processing #9
@bjendres bjendres changed the title Rename Message class Rename Message class? Dec 6, 2024
@bjendres bjendres changed the title Rename Message class? Minor changes Dec 6, 2024
@bjendres bjendres changed the title Minor changes Broader minor changes Dec 6, 2024
@bjendres
Copy link
Member Author

bjendres commented Dec 6, 2024

@jensschuppe Please create this minor - but global - changes as individual tickets, I tried changing them in the branch, but then the rebase failed and caused a bunch of extra work.

Let's do this when there's a good moment to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant