Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not create zwb_donation_receipt_item custom field group as multiple. #171

Closed
wants to merge 1 commit into from
Closed

Do not create zwb_donation_receipt_item custom field group as multiple. #171

wants to merge 1 commit into from

Conversation

muniodiego
Copy link
Contributor

No description provided.

@muniodiego muniodiego changed the title Update zwb_donation_receipt_item custom field group. @156 Update zwb_donation_receipt_item custom field group. #156 Sep 4, 2023
@muniodiego muniodiego mentioned this pull request Sep 4, 2023
Open
@jensschuppe jensschuppe requested a review from bjendres September 5, 2023 08:04
@jensschuppe jensschuppe added the status:needs review Code needs review and testing. label Sep 5, 2023
@jensschuppe jensschuppe linked an issue Sep 25, 2023 that may be closed by this pull request
Error when a contribution that has donrec data is duplicated - Stripe recurring contributions #156
Open
@jensschuppe jensschuppe changed the title Update zwb_donation_receipt_item custom field group. #156 Do not create zwb_donation_receipt_item custom field group as multiple. Sep 25, 2023
@jensschuppe
Copy link
Collaborator

I think this approach will not work, as the custom field group has to be multiple-value. There can be multiple receipt items per contribution, as there can be copies of receipts. @muniodiego have you thought about that scenario?

@jensschuppe jensschuppe added status:needs work There is code, but it needs additional work before it should be reviewed. and removed status:needs review Code needs review and testing. labels Sep 25, 2023
@jensschuppe jensschuppe added invalid and removed status:needs work There is code, but it needs additional work before it should be reviewed. labels Apr 9, 2024
@jensschuppe
Copy link
Collaborator

I'm closing this as invalid. Contribution entities used to not allow multi-value custom field groups, but they've been for a while now. Also, I'm sure the approach of having a single-record custom group with multi-value custom fields is not correct.

@jensschuppe jensschuppe closed this Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjendres bjendres Awaiting requested review from bjendres

Assignees
No one assigned
Labels
invalid
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error when a contribution that has donrec data is duplicated - Stripe recurring contributions
2 participants
@muniodiego @jensschuppe