PHPStan Static Code Analysis: Level 0

[jofranz]

Current scan on master (48068f7). Scan results:

 ------ ---------------------------------------------------------------------- 
  Line   CRM/Committees/CustomData.php                                         
 ------ ---------------------------------------------------------------------- 
  151    Call to an undefined static method CRM_Core_OptionGroup::getValue().  
 ------ ---------------------------------------------------------------------- 

 ------ ----------------------------------------------------------------------------------------------------------------------- 
  Line   CRM/Committees/Implementation/OxfamSimpleSync.php                                                                      
 ------ ----------------------------------------------------------------------------------------------------------------------- 
  514    Method CRM_Committees_Implementation_OxfamSimpleSync::syncModel() should return bool but return statement is missing.  
  991    Instantiated class CiviCRM_API3_Exception not found.                                                                   
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols                                                     
 ------ ----------------------------------------------------------------------------------------------------------------------- 

 ------ ------------------------------------------------------------------------------------------------------------------------------ 
  Line   CRM/Committees/Implementation/PersonalOfficeSyncer.php                                                                        
 ------ ------------------------------------------------------------------------------------------------------------------------------ 
  125    Call to an undefined method CRM_Committees_Implementation_PersonalOfficeSyncer::extractCurrentCommittees().                   
  174    Method CRM_Committees_Implementation_PersonalOfficeSyncer::extractCurrentContacts() invoked with 2 parameters, 3-4 required.  
  347    Call to an undefined method CRM_Committees_Implementation_PersonalOfficeSyncer::addCurrentMemberships().                      
  388    Access to undefined constant CRM_Committees_Implementation_PersonalOfficeSyncer::COMMITTEE_TRACKER_PREFIX.                    
  404    Method CRM_Committees_Implementation_PersonalOfficeSyncer::syncModel() should return bool but return statement is missing.    
  487    Caught class CiviCRM_API3_Exception not found.                                                                                
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols                                                            
  502    Caught class CiviCRM_API3_Exception not found.                                                                                
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols                                                            
 ------ ------------------------------------------------------------------------------------------------------------------------------ 

 ------ --------------------------------------------------------------------------------------------------------------------- 
  Line   CRM/Committees/Implementation/SessionSyncer.php                                                                      
 ------ --------------------------------------------------------------------------------------------------------------------- 
  387    Method CRM_Committees_Implementation_SessionSyncer::syncModel() should return bool but return statement is missing.  
  724    Caught class CiviCRM_API3_Exception not found.                                                                       
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols                                                   
 ------ --------------------------------------------------------------------------------------------------------------------- 

 ------ ----------------------------------------------------------------------------- 
  Line   CRM/Committees/Model/Email.php                                               
 ------ ----------------------------------------------------------------------------- 
  41     Result of method CRM_Committees_Model_Entity::__construct() (void) is used.  
 ------ ----------------------------------------------------------------------------- 

 ------ ----------------------------------------------------------------------------- 
  Line   CRM/Committees/Model/Url.php                                                 
 ------ ----------------------------------------------------------------------------- 
  37     Result of method CRM_Committees_Model_Entity::__construct() (void) is used.  
 ------ ----------------------------------------------------------------------------- 

 ------ --------------------------------------------------------------------- 
  Line   CRM/Committees/Plugin/Base.php                                       
 ------ --------------------------------------------------------------------- 
  438    Caught class CiviCRM_API3_Exception not found.                       
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols   
 ------ --------------------------------------------------------------------- 

 ------ --------------------------------------------------------------------- 
  Line   CRM/Committees/Plugin/Syncer.php                                     
 ------ --------------------------------------------------------------------- 
  109    Caught class CiviCRM_API3_Exception not found.                       
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols   
 ------ --------------------------------------------------------------------- 

 ------ ------------------------------------------------------------------------------------------------------------- 
  Line   CRM/Committees/Tools/IdTrackerTrait.php (in context of class CRM_Committees_Implementation_OxfamSimpleSync)  
 ------ ------------------------------------------------------------------------------------------------------------- 
  265    Access to protected property $idt_trackerID2contactIDbyPrefix of class CRM_Committees_Tools_IdTrackerTrait.  
 ------ ------------------------------------------------------------------------------------------------------------- 

 ------ ------------------------------------------------------------------------------------------------------------------ 
  Line   CRM/Committees/Tools/IdTrackerTrait.php (in context of class CRM_Committees_Implementation_PersonalOfficeSyncer)  
 ------ ------------------------------------------------------------------------------------------------------------------ 
  265    Access to protected property $idt_trackerID2contactIDbyPrefix of class CRM_Committees_Tools_IdTrackerTrait.       
 ------ ------------------------------------------------------------------------------------------------------------------ 

 ------ ------------------------------------------------------------------------------------------------------------- 
  Line   CRM/Committees/Tools/IdTrackerTrait.php (in context of class CRM_Committees_Implementation_SessionSyncer)    
 ------ ------------------------------------------------------------------------------------------------------------- 
  265    Access to protected property $idt_trackerID2contactIDbyPrefix of class CRM_Committees_Tools_IdTrackerTrait.  
 ------ ------------------------------------------------------------------------------------------------------------- 

 ------ ------------------------------------------------------------------------------------ 
  Line   committees.civix.php                                                                
 ------ ------------------------------------------------------------------------------------ 
  216    Call to static method instance() on an unknown class CRM_Committees_Upgrader_Base.  
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols                  
 ------ ------------------------------------------------------------------------------------ 

                                                                                                                        
 [ERROR] Found 20 errors                                                                                                
                                                                                                                        

[jofranz]

@bjendres Some scan results, as you are currently working on this ext

[bjendres]

@bjendres Some scan results, as you are currently working on this ext

Thanks! :-)