Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xps 9350 hotpatch #218

Open
maz-1 opened this issue Nov 26, 2018 · 107 comments
Open

xps 9350 hotpatch #218

maz-1 opened this issue Nov 26, 2018 · 107 comments
Assignees

Comments

@maz-1
Copy link
Collaborator

maz-1 commented Nov 26, 2018

After forking the-darkvoid's 9360 repo and some customizations, I made a working hotpatch configuration to run mojave on xps 13 9350

https://github.com/hackintosh-stuff/XPS9350-macOS

Currently type-c and card reader still need to be fixed, see the README

@PEHERA
Copy link

PEHERA commented Nov 26, 2018

Are you planning to make a working XPS9350.sh ?

@syscl
Copy link
Owner

syscl commented Nov 26, 2018

thats so cool! I’m currently at the end of the semester and exams are coming again, please let me know what I can help or do a pull request I will merge it! ;)

Thank you!

@maz-1
Copy link
Collaborator Author

maz-1 commented Nov 27, 2018

thats so cool! I’m currently at the end of the semester and exams are coming again, please let me know what I can help or do a pull request I will merge it! ;)

Thank you!

Still unable to sleep with type-c attached ... IOPCIFamily sometimes crash the machine, possibly something wrong with XHC2 detection.

@maz-1
Copy link
Collaborator Author

maz-1 commented Nov 27, 2018

Are you planning to make a working XPS9350.sh ?

Running that script is not necessary, after copying Clover folder you just need to do 5 things:

  • generate smbios
  • copy CPUFriend.kext and cpu profile (if yours is i7 6560u as well) to Clover
  • install ComboJack (for headset detection & startup fix)
  • install syscl-USBFix (fix usb ejected upon sleep/wake)
  • install BrcmPatchRAM2.kext and BrcmFirmwareRepo.kext (fix broadcom bluetooth)

@PEHERA
Copy link

PEHERA commented Nov 27, 2018

What in your Clover folder prevents me from booting from usb hd ?
It stops at Apple logo and in verbose mode nothing happens

@maz-1
Copy link
Collaborator Author

maz-1 commented Nov 27, 2018

What in your Clover folder prevents me from booting from usb hd ?
It stops at Apple logo and in verbose mode nothing happens

Your GPU?
You need to modify UEFI variable or add back DVMT-prealloc patches if not using iris graphics, as stated in readme.

@PEHERA
Copy link

PEHERA commented Nov 27, 2018

It is iris (i7 6560u QHD+)

@maz-1
Copy link
Collaborator Author

maz-1 commented Nov 27, 2018

It is iris (i7 6560u QHD+)

I just tried to boot Mojave 10.14.1 from my external ssd, works just fine (Clover folder from repo without any modification)
Do you have any hardware different from mine? Or different bios settings?

@PEHERA
Copy link

PEHERA commented Nov 27, 2018

I used bios settings from bozma88´s settings (not all off them available in my 1.9 bios)
https://www.tonymacx86.com/threads/guide-dell-xps-13-9360-on-macos-sierra-10-12-x-lts-long-term-support-guide.213141/
And I never had problems booting from external HD both 10.13.6 (HFS+) and an experimental 10.14.1. (APFS) SSHD
I just wanted to try out your solution but no go.

@PEHERA
Copy link

PEHERA commented Nov 27, 2018

I also disabled Touchscreen

@ltesla
Copy link

ltesla commented Nov 28, 2018

What in your Clover folder prevents me from booting from usb hd ?
It stops at Apple logo and in verbose mode nothing happens

Same problem while using clover directly, have you solved ?

@PEHERA
Copy link

PEHERA commented Nov 28, 2018

Same problem while using clover directly, have you solved ?
No

@maz-1
Copy link
Collaborator Author

maz-1 commented Nov 29, 2018

I used bios settings from bozma88´s settings (not all off them available in my 1.9 bios)
https://www.tonymacx86.com/threads/guide-dell-xps-13-9360-on-macos-sierra-10-12-x-lts-long-term-support-guide.213141/
And I never had problems booting from external HD both 10.13.6 (HFS+) and an experimental 10.14.1. (APFS) SSHD
I just wanted to try out your solution but no go.

Try to disable some dsdt fixes?

@PEHERA
Copy link

PEHERA commented Nov 29, 2018

Maybe the problem is as Rehabman wrote here:
https://www.tonymacx86.com/threads/success-dell-xps-13-9350-4k.261856/page-2#post-1861802
Patched ACPI files cannot be shared.
The reason is documented in the guide:
https://www.tonymacx86.com/threads/guide-patching-laptop-dsdt-ssdts.152573/

@PEHERA
Copy link

PEHERA commented Nov 29, 2018

So I think the way to go, if you have time and skills, is to make a working XPS9350.sh that will use files from (F4) EFI/CLOVER/ACPI/origin to make the patched

@maz-1
Copy link
Collaborator Author

maz-1 commented Nov 29, 2018

So I think the way to go, if you have time and skills, is to make a working XPS9350.sh that will use files from (F4) EFI/CLOVER/ACPI/origin to make the patched

Hotpatch is intended to avoid this...

@PEHERA
Copy link

PEHERA commented Nov 29, 2018

I tried to reset bios (1.9) to default and only change raid to achi and disabled secure boot.
Still not working.
It stops at Apple logo and in verbose mode nothing happens.
By disable some DSDT fixes do you mean in config.plist or ?

@maz-1
Copy link
Collaborator Author

maz-1 commented Nov 29, 2018

I tried to reset bios (1.9) to default and only change raid to achi and disabled secure boot.
Still not working.
It stops at Apple logo and in verbose mode nothing happens.
By disable some DSDT fixes do you mean in config.plist or ?

Do you mean you are stuck at plus-line when boot verbose?
It could be a problem with efi drivers instead of dsdt configuration
I am using m.2 sata ssd, so it is highly possible that NvmExpressDxe-64.efi will cause problem when using nvme ssd...

@PEHERA
Copy link

PEHERA commented Nov 29, 2018

Yes I´m using nvme.Tried to remove the NvmExpressDxe-64.efi but still the same.
Is there anything in config.plist related to that ?
Or in patched folder ?

@PEHERA
Copy link

PEHERA commented Nov 29, 2018

Yes stuck at the + line

@maz-1
Copy link
Collaborator Author

maz-1 commented Nov 29, 2018

Yes stuck at the + line

send me the dsdt file?

@PEHERA
Copy link

PEHERA commented Nov 29, 2018

I´m using clover from your latest repo so i don't think I have anything different from what you already have.

@maz-1
Copy link
Collaborator Author

maz-1 commented Nov 29, 2018

I´m using clover from your latest repo so i don't think I have anything different from what you already have.

I mean your dumped dsdt file
I am not using nvme so nvme-related entries are missing in my dsdt.

@PEHERA
Copy link

PEHERA commented Nov 29, 2018

Ahhh ok. But i´m not using the nvme.I´m using external USB SSHD
DSDT.aml.zip

@PEHERA
Copy link

PEHERA commented Nov 29, 2018

On my nvme I have at really great working 10.13.6 and I won't upgrade to Mojave before all issues are solved

@PEHERA
Copy link

PEHERA commented Nov 29, 2018

Why can't we comment on your GitHub ?
I think its a little odd to use Syscl´s for that

@maz-1
Copy link
Collaborator Author

maz-1 commented Nov 29, 2018

Why can't we comment on your GitHub ?
I think its a little odd to use Syscl´s for that

You can always add an issue there...

@PEHERA
Copy link

PEHERA commented Nov 29, 2018

Ok I first signed up a few days ago so I apparently have much to learn

@PEHERA
Copy link

PEHERA commented Nov 30, 2018

Your updated repo is working great with nvme.
Everything, so far , is working .Only thing not testet is sleep/wake (testing on USB3 SSHD)
Its very late here in Denmark so tomorrow I´ll CarbonCopyClone to nvme and report if I have issues
Thank you very much for your hard work and patience.
Just a little cosmetic issue in config.plist I changed Boot Graphics/UIScale from 0 to 2 for a more even sized Apple logo during bootproces

@ltesla
Copy link

ltesla commented Nov 30, 2018

So I think the way to go, if you have time and skills, is to make a working XPS9350.sh that will use files from (F4) EFI/CLOVER/ACPI/origin to make the patched

Hotpatch is intended to avoid this...

弱弱的问一句,为何Hotpatch 要avoid这个呀? (类似 syscl 那种 利用terminal 打补丁?)还有 是不是说 直接拷贝到 Clover就可以用了(不用设置超频啥的)呢?

@maz-1
Copy link
Collaborator Author

maz-1 commented Dec 11, 2018

Hi maz-1
Which one of the .aml´s in patched are for cardreader ?
and what is NoTouchID.kext for ?

Card reader simply doesn't work yet, the driver is still under development
I added NoTouchID.kext because I see TouchID setup with fresh install, so better add this to bypass biometric authentication.

@PEHERA
Copy link

PEHERA commented Dec 11, 2018

Hi maz-1
Which one of the .aml´s in patched are for cardreader ?
and what is NoTouchID.kext for ?

Card reader simply doesn't work yet, the driver is still under development
I added NoTouchID.kext because I see TouchID setup with fresh install, so better add this to bypass biometric authentication.
Ok I´m asking because if I disable cardreader in bios the frequencies in IntelPowerGadget almost newer go to 0,5 Ghz but stays arround 0,7- 0,9 Ghz but the PKG value is lower
Whats your opinion to that ?
bozma88 in tonymacx86 claims that disable cardreader in bios should gain 5% battery life

@PEHERA
Copy link

PEHERA commented Dec 11, 2018

In Readme
"Put FakePCIID_Broadcom_WiFi.kext and FakePCIID.kext in Clover/kexts/Other if you have DW1560."
I have the DW1560 and I only need AirportBrcmFixup.kext.
https://www.tonymacx86.com/threads/broadcom-wifi-bluetooth-guide.242423/

@PEHERA
Copy link

PEHERA commented Dec 15, 2018

@ maz-1
I noticed that if I disable cardreader in bios frequency newer reach 0,5 Ghz (idle) but stay between 0,7 - 0,9.
The overall power draw is though lower compared to enabled.
This is no matter undervolt enabled or disabled.
I tried to switch sys.def to MBP 13,2 to se if sys.def MB 9,1 was causing it
But same result.
Any idea ?

skaermbillede 2018-12-15 kl 16 15 03

@maz-1
Copy link
Collaborator Author

maz-1 commented Dec 19, 2018

@ maz-1
I noticed that if I disable cardreader in bios frequency newer reach 0,5 Ghz (idle) but stay between 0,7 - 0,9.
The overall power draw is though lower compared to enabled.
This is no matter undervolt enabled or disabled.
I tried to switch sys.def to MBP 13,2 to se if sys.def MB 9,1 was causing it
But same result.
Any idea ?

I think 0.5ghz and 0.7ghz does not make much difference

@maz-1
Copy link
Collaborator Author

maz-1 commented Dec 22, 2018

Made some progress on type-c hotplug
With the help of IOElectrify and some undocumented API I can force-power thunderbolt and eject usb 3.1 controller from userspace. But unplug/replug causes panic in some cases.
Turn off thunderbolt controller when machine is awake is not possible as it will cause panic.

https://github.com/hackintosh-stuff/XPS9350-macOS/blob/master/sources/USBFix/USBFix/main.m
https://github.com/hackintosh-stuff/macOS-IOElectrify

@Xplic1T
Copy link

Xplic1T commented Dec 23, 2018

Are you planning to make a working XPS9350.sh ?

Running that script is not necessary, after copying Clover folder you just need to do 5 things:

  • generate smbios
  • copy CPUFriend.kext and cpu profile (if yours is i7 6560u as well) to Clover
  • install ComboJack (for headset detection & startup fix)
  • install syscl-USBFix (fix usb ejected upon sleep/wake)
  • install BrcmPatchRAM2.kext and BrcmFirmwareRepo.kext (fix broadcom bluetooth)

Thanks for this run-through !

@syscl
Copy link
Owner

syscl commented Jan 1, 2019

OK, I know most of you guys expect a flashing dynamic ACPI patching through Clover which I am also working on it, but there's some big flaws lies in the hot patching method until now.

Things we have to consider for ACPI patching is:

  • Proper ACPI code such that there won't be improper interrupts being generated that will cause the system unstable
  • Remove or override properties of some devices such as HDEF, PPMC, PMCR and ALS0, ...
  • Avoid duplicate devices being injected
  • Resolve the common decompile errors, Zeros, MDBG(0) and etc.
  • Resolves several warnings
  • ...

Clover hot patching can perform rename and apply limited patches during booting, but still far from the things we can resolve by a simply static ACPI patching using deploy.sh.

@maz-1
Copy link
Collaborator Author

maz-1 commented Jan 5, 2019

OK, I know most of you guys expect a flashing dynamic ACPI patching through Clover which I am also working on it, but there's some big flaws lies in the hot patching method until now.

Clover's dsdt patching functionality has been improved, and now there is an extended usage of clover hotpatch: rename original methods/properties in dsdt so they will never be invoked/read, and reimplement them in ssdt files.
https://github.com/RehabMan/OS-X-Clover-Laptop-Config
I have ported most static dsdt patches to hotpatch+ssdts.

@ltesla
Copy link

ltesla commented Jan 9, 2019

OK, I know most of you guys expect a flashing dynamic ACPI patching through Clover which I am also working on it, but there's some big flaws lies in the hot patching method until now.

Clover's dsdt patching functionality has been improved, and now there is an extended usage of clover hotpatch: rename original methods/properties in dsdt so they will never be invoked/read, and reimplement them in ssdt files.
https://github.com/RehabMan/OS-X-Clover-Laptop-Config
I have ported most static dsdt patches to hotpatch+ssdts.

; ) thx.

@wuhengjiang
Copy link

After forking the-darkvoid's 9360 repo and some customizations, I made a working hotpatch configuration to run mojave on xps 13 9350

https://github.com/hackintosh-stuff/XPS9350-macOS

Currently type-c and card reader still need to be fixed, see the README

麻烦问一下我机器是9350,区别是硬盘为pm961,cpu是6200u,我发现机器用起来挺好,就是黑屏以后会出现不定期闪烁。是需要做哪些修改么,可以指导一下么?

@maz-1
Copy link
Collaborator Author

maz-1 commented Jan 24, 2019

麻烦问一下我机器是9350,区别是硬盘为pm961,cpu是6200u,我发现机器用起来挺好,就是黑屏以后会出现不定期闪烁。是需要做哪些修改么,可以指导一下么?

黑屏后没有睡眠吗

@wuhengjiang
Copy link

麻烦问一下我机器是9350,区别是硬盘为pm961,cpu是6200u,我发现机器用起来挺好,就是黑屏以后会出现不定期闪烁。是需要做哪些修改么,可以指导一下么?
黑屏后没有睡眠吗

有睡眠,唤醒以后屏幕不定时的闪,几十秒一次吧。重启就ok了。

@maz-1
Copy link
Collaborator Author

maz-1 commented Jan 26, 2019

有睡眠,唤醒以后屏幕不定时的闪,几十秒一次吧。重启就ok了。

显示器是1080p还是3k
repo里只有3k的显示器配置文件,1080p的可能要按照这个方法修复edid:http://bbs.pcbeta.com/forum.php?mod=viewthread&tid=1767983&highlight=

@wuhengjiang
Copy link

有睡眠,唤醒以后屏幕不定时的闪,几十秒一次吧。重启就ok了。

显示器是1080p还是3k
repo里只有3k的显示器配置文件,1080p的可能要按照这个方法修复edid:http://bbs.pcbeta.com/forum.php?mod=viewthread&tid=1767983&highlight=

我也是3k的触摸屏。莫非9350有几个版本的屏幕?

@maz-1
Copy link
Collaborator Author

maz-1 commented Jan 27, 2019

我也是3k的触摸屏。莫非9350有几个版本的屏幕?

3k应该只有一个型号的屏幕,不过可能只有hd520会有这种问题
你可以试着修复edid

@wuhengjiang
Copy link

我也是3k的触摸屏。莫非9350有几个版本的屏幕?

3k应该只有一个型号的屏幕,不过可能只有hd520会有这种问题
你可以试着修复edid

果然就是解决了。我看了下,删掉了以后也是不会出现闪烁问题的。144a这个屏幕默认就不需要改那个A5的值,我把windows提取的edid添加进去就OK了。

@dogaoz
Copy link

dogaoz commented Jan 31, 2019

My screen doesn't wake up at all if it ever turns off itself on sleep or login screen timeout. I can hear the music playing in the back, so I can tell everything is still working. Could anyone find solution to this?

@maz-1 maz-1 self-assigned this Feb 13, 2019
@maz-1 maz-1 pinned this issue Feb 13, 2019
@DanielKng
Copy link

DanielKng commented Mar 14, 2019

Okay.
So I just created my USB-Stick with the most recent Mojave Installer.
I installed Clover on it, mounted the EFI-Partition, got rid of the CLOVER-Folder and used the one from this Repo instead.

I've updated the BIOS to the latest Version and set it to "UEFI Only", beside "AHCI" and turning "Secure boot off".

I pressed F12 to boot from it. Once i saw the CLOVER-Bootloader, i pressed F4 to get the required ACPI-Tables.

Now comes my Issue
The Apple-Loadingbar gets stuck about 3/4th of its way. Using the verbose mode, this is the Error i get:
https://s17.directupload.net/images/190314/7tw72fnq.jpg

It repeats about 3 Times, each one taking 240s. After that, I've got a Error that reads as follows:
"Window server exited to SIGABRT"
After that it just does nothing. No reboot, no Shutdown.

I would love to get any help, I would really appreciate it! :)

Edit: I've got an IOG: 0x3(0x53) Error. That means something isn't right with my Intel HD I guess? Any clue? :/

@ltesla
Copy link

ltesla commented Mar 17, 2019

IMG_4251
嗨,似乎在 最新的版本 mojave 10.14.4 beta 5中,无法进入系统界面,卡在了进度条加载那,不知道该怎么办,我替换了 Clover之后还是不行。

@SoulBlaze4j
Copy link

我也是3k的触摸屏。莫非9350有几个版本的屏幕?

3k应该只有一个型号的屏幕,不过可能只有hd520会有这种问题
你可以试着修复edid

果然就是解决了。我看了下,删掉了以后也是不会出现闪烁问题的。144a这个屏幕默认就不需要改那个A5的值,我把windows提取的edid添加进去就OK了。

请问你只是将原来的文件中的edid改了一下就解决闪烁了吗?为何我更改了还是会有闪烁

@x4080
Copy link

x4080 commented Apr 7, 2019

Hi, after long boot using mojave 14.4 boot disk, the installation screen appears, but keyboard and trackpad is not working, is this supposed to be or there's something break?

Thanks

@maz-1
Copy link
Collaborator Author

maz-1 commented Apr 26, 2019

Hi, after long boot using mojave 14.4 boot disk, the installation screen appears, but keyboard and trackpad is not working, is this supposed to be or there's something break?

Thanks

Use usb mouse/keyboard during installation and first boot-up
Run sudo kextcache -i / after booted into installed os to make VoodooI2C working.

@maz-1
Copy link
Collaborator Author

maz-1 commented Apr 26, 2019

嗨,似乎在 最新的版本 mojave 10.14.4 beta 5中,无法进入系统界面,卡在了进度条加载那,不知道该怎么办,我替换了 Clover之后还是不行。

刚更新了驱动文件和clover,更新到14.4没出问题
已经上传了最新的驱动和clover

@x4080
Copy link

x4080 commented Apr 30, 2019

Hi, after long boot using mojave 14.4 boot disk, the installation screen appears, but keyboard and trackpad is not working, is this supposed to be or there's something break?
Thanks

Use usb mouse/keyboard during installation and first boot-up
Run sudo kextcache -i / after booted into installed os to make VoodooI2C working.

Thanks

@ltesla
Copy link

ltesla commented May 12, 2019

你好,我想请问下如何开启Handoff在设备间剪切板互通的这个功能呀?

@wuhengjiang
Copy link

我也是3k的触摸屏。莫非9350有几个版本的屏幕?

3k应该只有一个型号的屏幕,不过可能只有hd520会有这种问题
你可以试着修复edid

果然就是解决了。我看了下,删掉了以后也是不会出现闪烁问题的。144a这个屏幕默认就不需要改那个A5的值,我把windows提取的edid添加进去就OK了。

请问你只是将原来的文件中的edid改了一下就解决闪烁了吗?为何我更改了还是会有闪烁

如果你跟我一样是HD520显卡,需要在SSDT-Config.aml这个文件里的IGPI后面替换成0x19160000

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants