Pick #98 / #111 (SIF adjacent) to release-3.8 #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dtrudg
commented
Jul 15, 2021
dtrudg
commented
- Fix TestSIFInitializer Unit Test Fix TestSIFInitializer Unit Test #98
- Partially Replace UUID Module Partially Replace UUID Module #111
added 2 commits
July 15, 2021 17:06
Fix inconsistent writable flag usage. Leverage subtests to improve readability of results. Simplify error check logic.
The github.com/satori/go.uuid package is no longer maintained. We cannot fully replace this yet because the github.com/sylabs/sif API requires it. For now, replace all other uses of github.com/satori/go.uuid with github.com/google/uuid.
|
Just noticed that the test fix dropped to an empty commit here. Can remove it from the PR if you wish, or leave it in. |
tri-adam
approved these changes
Jul 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.