Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new load DDS event #1381

Closed
1 task done
sxyazi opened this issue Aug 1, 2024 · 2 comments · Fixed by #1980
Closed
1 task done

Add a new load DDS event #1381

sxyazi opened this issue Aug 1, 2024 · 2 comments · Fixed by #1980
Labels
feature New feature request
Milestone

Comments

@sxyazi
Copy link
Owner

sxyazi commented Aug 1, 2024

Please describe the problem you're trying to solve

I discussed with @Rolv-Apneseth on Discord about adding a new load event to make implementing bypass.yazi easier.

I just tried some changes in #1374 and found that a larger-scale refactor is needed to make it work. Specifically, the yazi_dds crate can't access the FolderStage in yazi_core because yazi_dds is a dependency of yazi_core, which would cause a circular dependency.

So, I'll track it in this issue and implement it in the next target (0.3.1).

Would you be willing to contribute this feature?

  • Yes, I'll give it a shot

Describe the solution you'd like

.

Additional context

No response

@sxyazi sxyazi added the feature New feature request label Aug 1, 2024
@sxyazi sxyazi added this to the v0.3.1 milestone Aug 1, 2024
@Rolv-Apneseth
Copy link
Contributor

That's great, thank you. Sounds tricky.

@sxyazi
Copy link
Owner Author

sxyazi commented Dec 3, 2024

Please try #1980

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants