Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception when no root specified #68

Open
flahertyb opened this issue Jul 24, 2015 · 4 comments
Open

Exception when no root specified #68

flahertyb opened this issue Jul 24, 2015 · 4 comments

Comments

@flahertyb
Copy link
Contributor

We're used to always having '/partners' - but when no root is specified (and it defaults to ""), you get an invalid RegEx from this guy:

  /**
  @method _removeURIRoot
  @param {String} uri '/partners/s/foo-bar'
  @return {String} uri '/s/foo-bar'
  **/
  _removeURIRoot: function (uri) {
    var rootRegex = new RegExp('^' + this.root);

    return uri.replace(rootRegex, '');
  }
@barnabyc
Copy link
Contributor

Ah, yes, we definitely assume a prefix but should be straight forward to accommodate without.

@barnabyc
Copy link
Contributor

@flahertyb were you able to work around/fix this? Would love if you were able to open a PR.

@flahertyb
Copy link
Contributor Author

ERROR: Permission to swipely/aviator.git denied to flahertyb.
fatal: Could not read from remote repository.

:(

@hojberg
Copy link
Contributor

hojberg commented Dec 18, 2015

@flahertyb oh i didn't realize. I added you as a collaborator now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants