This repository has been archived by the owner on Apr 13, 2021. It is now read-only.
Work saturdays #200
Merged
Work saturdays #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test PASSed. |
henryhallam
force-pushed
the
work_saturdays
branch
from
de92616 to
e947cd7
Compare
|
Test PASSed. |
|
@henryhallam Can you add an issue for invalidating out of date ephemerides? |
|
Issue created swift-nav/piksi_firmware#523 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't claim that this is the most rigorous possible way of handling time-of-week rollovers, but it's better than keeling over.
In this edition, the tracking channel doesn't attempt to keep track of the week number. Instead when it's time to form a measurement, it uses gps_time_match_week() to set the measurement week number appropriately from the ephemeris, which may be equal, a week ahead or a week behind.
Bad results are still possible if we happen to have a cached ephemeris that's 7 days out of date and try to use it at just the wrong time. A separate piksi_firmware update will regularly invalidate outdated ephemerides to prevent that from happening.
@mookerji @fnoble @cbeighley @denniszollo