You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Due to changing to a new version of Jasmine we had to rewrite all async tests. To get back to a green bar we took the shortcut and often replaced runs and waitsFor with stupid setTimeout blocks that will wait for 100ms rather waiting at most 100ms. This slows down 30% of all tests.
To speed up tests again, we should try to replace those blocks with proper event handlers, i.e. expect and done are called inside an event handler that waits for the previous action to be completed. It might be required to inject more events for testing.
Originally reported by: Florian Pilz (Bitbucket: florianpilz, GitHub: florianpilz)
Due to changing to a new version of Jasmine we had to rewrite all async tests. To get back to a green bar we took the shortcut and often replaced
runs
andwaitsFor
with stupidsetTimeout
blocks that will wait for 100ms rather waiting at most 100ms. This slows down 30% of all tests.To speed up tests again, we should try to replace those blocks with proper event handlers, i.e.
expect
anddone
are called inside an event handler that waits for the previous action to be completed. It might be required to inject more events for testing.The text was updated successfully, but these errors were encountered: