Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emotion plugin should not use Path::new #79

Open
kdy1 opened this issue Aug 25, 2022 · 2 comments
Open

emotion plugin should not use Path::new #79

kdy1 opened this issue Aug 25, 2022 · 2 comments

Comments

@kdy1
Copy link
Member

kdy1 commented Aug 25, 2022

let path = Path::new(&file_name);

This will be broken on windows

@Codex-
Copy link
Contributor

Codex- commented Jan 12, 2024

I ran the emotion fixture suite and builds on windows to see if this was still an issue and it seems to work now, is this what you find too? Can probably close this if so

@kdy1
Copy link
Member Author

kdy1 commented Jan 30, 2024

@Codex- The problem is that the plugin is compiled as a Wasm binary, which uses / as the path separator even on windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants