feat: personalised ical feed #1101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SilasPeters
force-pushed
the
feat/personalised-ical-feed
branch
from
3d4b6d5 to
9f1a972
Compare
SilasPeters
force-pushed
the
feat/personalised-ical-feed
branch
4 times, most recently
from
33f7792 to
7c17300
Compare
|
I now realise that there are also activities where you cannot sign up for. This might raise confusion, for you bought a pretix ticket but the activity does not appear in your calendar. I should add some clarification on what exactly the personalized calendar feed is, or add a checkbox next to every activity to include the activity in your calendar, where it is automatically checked when you sign up. |
SilasPeters
force-pushed
the
feat/personalised-ical-feed
branch
from
b6fd936 to
7f35699
Compare
SilasPeters
requested review from
Siem2l and
stickyPiston
and removed request for
Siem2l and
stickyPiston
SilasPeters
force-pushed
the
feat/personalised-ical-feed
branch
from
7f35699 to
729f0c3
Compare
|
Also on a separate note: it might be nice to mention how to import the personalised calendar into one's own calendar app somewhere. But i'd love to see this feature get merged as soon as possible first. |
SilasPeters
requested review from
stickyPiston
and removed request for
Siem2l
SilasPeters
added a commit
that referenced
this pull request
Nov 19, 2024
This reverts commit 01c3d07.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduced a new button, 'Copy personalised Webcal link`, which copies the link to your ical feed which any calendar client can use to visualise the activities where you are enrolled.
It also adds clarification on the difference between the ical feed and the ical templates
This will close #1037