ZnBufferedReadStream>>upToEnd returns nil when reading contents of an empty file

[jbrichau]

Case: I am reading the contents of an empty (binary) file and expect to get an empty instance of ByteArray. I now get a nil as a result instead.

This is because the ZnBufferedReadStream>>upToEnd returns nil for such a case.
The following test in Grease illustrates the issue:
GRPlatformTest>> testReadWriteEmptyFileInFolderBinary

This test fails in Pharo 10 since recently only. Probably because the latest Zinc version was included recently? I have not investigated the changes. It was tested in:

Pharo 10.0.0 Build information: Pharo-10.0.0+build.483.sha.95c615fd186704d9ae9b2d2355680145b9646774 (64 Bit)

To reproduce in Pharo 10, load Grease

Metacello new
 baseline:'Grease';
 repository: 'github://SeasideSt/Grease:master/repository';
 load:'Tests'

and execute the test testReadWriteEmptyFileInFolderBinary on GRPlatformTest

[jbrichau]

A fix might be to change the following line

zinc/repository/Zinc-Character-Encoding-Core.package/ZnBufferedReadStream.class/instance/upToEnd.st

Line 25 in c6f2f61

^result

with:

^ result ifNil:[ self collectionSpecies new ]

[svenvc]

Hi @jbrichau

Thanks for the report: this is indeed wrong. The code is also a bit weird, but somebody will have had a reason to write it this way at one point in time I guess (maybe related to reading from stdin).

Anyway here is the fix: 66612d4

Sven

[jbrichau]

thanks for the quick response @svenvc !