Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add Zinc-Server-Sent-Events package to BaselineOfZincHTTPComponents #54

Closed
mumez opened this issue Jul 3, 2020 · 5 comments
Closed

Comments

@mumez
Copy link
Contributor

mumez commented Jul 3, 2020

It is difficult to load Zinc-Server-Sent-Events package from this site for now. Please add an optional 'SSE' group to BaselineOfZincHTTPComponents.

@svenvc
Copy link
Owner

svenvc commented Jul 3, 2020

Hi,

I can do that, but honestly I can't remember anything about this.

I assume you are still using this and can confirm it still works today on recent Pharo versions ?

Sven

@mumez
Copy link
Contributor Author

mumez commented Jul 4, 2020

Zinc-Server-Sent-Events runs nicely on Pharo 6.1 and 7.0.5.
It has been used about 3 years for allstocker.com.
Our team is just starting to use Phato 8, so we are not sure it works on Pharo 8, but we can contribute if we find some problems.

@svenvc
Copy link
Owner

svenvc commented Jul 5, 2020

OK, thank you for the feedback.

Does the following work for you ?

f11f1a9

Do you think it would be difficult to add at least one test (in a separate package) ? You could have a look at the WebSockets implementation for inspiration.

@mumez
Copy link
Contributor Author

mumez commented Jul 6, 2020

Thank you for the quick response!
I've confirmed Zinc-Server-Sent-Events was successfully loaded.

Metacello new
  repository: 'github://svenvc/zinc/repository';
  baseline: 'ZincHTTPComponents';
  load: #('Core' 'Server-Sent-Events' ).

I will also try to add a unit test.
BTW, sometimes ZnClient fails to request POST with some big payload. Our team now investigating the issue. I'll report this too.

@svenvc
Copy link
Owner

svenvc commented Jul 7, 2020

OK, great.

Thank you.

@svenvc svenvc closed this as completed Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants