Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

push changes from squeaksource to github #2

Closed
pdebruic opened this issue Jul 12, 2012 · 8 comments
Closed

push changes from squeaksource to github #2

pdebruic opened this issue Jul 12, 2012 · 8 comments

Comments

@pdebruic
Copy link

Hi Sven,

Will you please push the recent set of packages from squeaksource to github? I'll work on incorporating them into the gemstone port sometime soon

@svenvc
Copy link
Owner

svenvc commented Jul 12, 2012

OK. Paul.
I will try to do it in the next couple of days and let you know.

Sven

@pdebruic
Copy link
Author

Hi Sven.

I think I can just export the new packages from Pharo into git myself and issue you a pull request from my fork. Dale has added the ability to track the author/timestamp of methods in FileTree so your authorship of the code won't get lost if I do it. It'll just be me making the commit rather than you.

Let me know if that's OK and I'll get started. I think it'll also make your life a bit easier as all you'll have to do is merge the pull request rather than messing about with git.

@svenvc
Copy link
Owner

svenvc commented Jul 12, 2012

OK, go ahead then.
I hope things don't diverge too much.

Keep in mind that there is a new package called 'Zinc-FileSystem-Legacy' / 'Zinc-FileSystem', the former is pre Pharo 2.0, the latter post 2.0.

Sven

On 12 Jul 2012, at 19:03, Paul DeBruicker wrote:

Hi Sven.

I think I can just export the new packages from Pharo into git myself and issue you a pull request from my fork. Dale has added the ability to track the author/timestamp of methods in FileTree so your authorship of the code won't get lost if I do it. It'll just be me making the commit rather than you.

Let me know if that's OK and I'll get started. I think it'll also make your life a bit easier as all you'll have to do is merge the pull request rather than messing about with git.


Reply to this email directly or view it on GitHub:
#2 (comment)

@pdebruic
Copy link
Author

Your Zinc-HTTP-Components.svc.284.mcz does not descend from
Zinc-HTTP-Components.svc.283.mcz or Zinc-HTTP-Components.svc.282.mcz so
the tests in ZnUrlTests>>testConvenienceMethods fail.

I can't merge 284 and 283 on my own because I don't know where to look
for Zinc-HTTP-Components.MarkusDenker.282.mcz

Let me know how I can help sort it out, when you fix it, or if I should
just ignore it for now.

thanks

Paul

On 07/12/2012 11:14 AM, Sven Van Caekenberghe wrote:

OK, go ahead then.
I hope things don't diverge too much.

Keep in mind that there is a new package called 'Zinc-FileSystem-Legacy' / 'Zinc-FileSystem', the former is pre Pharo 2.0, the latter post 2.0.

Sven

On 12 Jul 2012, at 19:03, Paul DeBruicker wrote:

Hi Sven.

I think I can just export the new packages from Pharo into git myself and issue you a pull request from my fork. Dale has added the ability to track the author/timestamp of methods in FileTree so your authorship of the code won't get lost if I do it. It'll just be me making the commit rather than you.

Let me know if that's OK and I'll get started. I think it'll also make your life a bit easier as all you'll have to do is merge the pull request rather than messing about with git.


Reply to this email directly or view it on GitHub:
#2 (comment)


Reply to this email directly or view it on GitHub:
#2 (comment)

@svenvc
Copy link
Owner

svenvc commented Jul 12, 2012

??

I did not yet see that, you'll have to give me some time, I am hacking in Zn right now.

I'll let you known when I sorted things out.

Sorry for the mess ;-)

On 12 Jul 2012, at 20:47, Paul DeBruicker wrote:

Your Zinc-HTTP-Components.svc.284.mcz does not descend from
Zinc-HTTP-Components.svc.283.mcz or Zinc-HTTP-Components.svc.282.mcz so
the tests in ZnUrlTests>>testConvenienceMethods fail.

I can't merge 284 and 283 on my own because I don't know where to look
for Zinc-HTTP-Components.MarkusDenker.282.mcz

Let me know how I can help sort it out, when you fix it, or if I should
just ignore it for now.

@pdebruic
Copy link
Author

OK. I'll wait until I hear from you. Please don't hurry or prioritize
this stuff on my account. Thanks again

Paul

On 07/12/2012 11:55 AM, Sven Van Caekenberghe wrote:

??

I did not yet see that, you'll have to give me some time, I am hacking in Zn right now.

I'll let you known when I sorted things out.

Sorry for the mess ;-)

On 12 Jul 2012, at 20:47, Paul DeBruicker wrote:

Your Zinc-HTTP-Components.svc.284.mcz does not descend from
Zinc-HTTP-Components.svc.283.mcz or Zinc-HTTP-Components.svc.282.mcz so
the tests in ZnUrlTests>>testConvenienceMethods fail.

I can't merge 284 and 283 on my own because I don't know where to look
for Zinc-HTTP-Components.MarkusDenker.282.mcz

Let me know how I can help sort it out, when you fix it, or if I should
just ignore it for now.


Reply to this email directly or view it on GitHub:
#2 (comment)

@svenvc
Copy link
Owner

svenvc commented Jul 20, 2012

Paul,

On 12 Jul 2012, at 20:59, Paul DeBruicker wrote:

OK. I'll wait until I hear from you. Please don't hurry or prioritize
this stuff on my account. Thanks again

The current Zn version in either

http://mc.stfx.eu/ZincHTTPComponents

or

http://www.squeaksource.com/ZincHTTPComponents

should be OK.

Regards,

Sven

@pdebruic
Copy link
Author

Thanks Sven,

I'll let you know how it goes.

Paul

On 07/20/2012 04:47 AM, Sven Van Caekenberghe wrote:

Paul,

On 12 Jul 2012, at 20:59, Paul DeBruicker wrote:

OK. I'll wait until I hear from you. Please don't hurry or prioritize
this stuff on my account. Thanks again

The current Zn version in either

http://mc.stfx.eu/ZincHTTPComponents

or

http://www.squeaksource.com/ZincHTTPComponents

should be OK.

Regards,

Sven


Reply to this email directly or view it on GitHub:
#2 (comment)

@svenvc svenvc closed this as completed Oct 20, 2017
svenvc pushed a commit that referenced this issue May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants