Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'next steps' should omit git init if we are already in a git repo #287

Open
Rich-Harris opened this issue Nov 9, 2024 · 3 comments · May be fixed by #325
Open

'next steps' should omit git init if we are already in a git repo #287

Rich-Harris opened this issue Nov 9, 2024 · 3 comments · May be fixed by #325

Comments

@Rich-Harris
Copy link
Member

If you're creating a new app inside a git repo, 'next steps' includes this...

git init && git add -A && git commit -m "Initial commit" (optional)

...and it should probably just say nothing

@dominikg
Copy link
Member

dominikg commented Nov 9, 2024

i'd be in favor of turning the option around entirely
automatically call git init unless --no-git-init was passed or we are in a git project already.
if one was initialized, add "we initialized git for you, if you don't need that, run `rm -rf .git" to next steps

(edit: only if git is installed, we are in a tty and CI is false)

@AdrianGonz97
Copy link
Member

I think we should just get rid of it. It's unnecessary clutter for people that already know git, and it's a line full of funny words and symbols for those that don't. It's not very helpful in either case

@BlankParticle
Copy link
Contributor

I think best option would be to ask to initialise a git repo if git is installed and the directory is already not a git repo.

example from create-remix
image

@BlankParticle BlankParticle linked a pull request Nov 22, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants