Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding better handling for kernel cmdline arguments #605

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rdoxenham
Copy link
Contributor

In this PR we introduce better handling of kernel cmdline arguments, specifically:

  1. Strip out duplicates in both raw and iso boot, as to avoid relying on the order in which they're applied and ensuring that Kiwi-supplied kernel cmdline arguments aren't overriding user-supplied ones.
  2. Remove the repliance on rd.kiwi.install.pass.bootparam which ended up being a bit of a hack just to get kernel cmdline arguments into the system post-kexec.
  3. Insertion of desired kernel cmdline arguments into both iso and raw image booting so the resulting systems cleanly apply

Note that there's not yet a mechanism to remove kernel cmdline arguments, and the supplied code just ignores duplicated kernel cmdline arguments that do not have a value, as having these duplicated doesn't really matter.

Related: suse-edge/nm-configurator#122
Fixes: #604 #369

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle kernel arguments better, especially when duplicated
1 participant