Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete documentation for [[services.http_checks]] section #1899

Open
DmitriyAlergant-T1A opened this issue Jan 3, 2025 · 0 comments
Open

Comments

@DmitriyAlergant-T1A
Copy link

I found an issue with this document.

Title: App configuration (fly.toml)
Location: https://fly.io/docs/reference/configuration/
Source: https://github.com/superfly/docs/blob/main/reference/configuration.html.markerb

Describe the issue

The document provides example of the [[services.http_checks]] section, however it does not indicate where this section should be placed.

When placed at the top level of the fly.toml, which is most logical for those new to TOML, the http checks goes against port 8080, ignoring any custom internal port that may have been configured under the[[http_service]] section. I discovered that in order to go against the correct port, the [[services.http_checks]] needs to be placed under the [[services]] section that has defined the internal port.

This is an opportunity to improve the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant