Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with the "Git Branch Preview Environments on Github" doc #1894

Open
WilliamFernsV3 opened this issue Dec 27, 2024 · 1 comment
Open

Comments

@WilliamFernsV3
Copy link

I found an issue with this document.

Title: Git Branch Preview Environments on Github
Location: https://fly.io/docs/blueprints/review-apps-guide/
Source: https://github.com/superfly/docs/blob/main/blueprints/review-apps-guide.html.md

Describe the issue

Most of the documentation uses "superfly/[email protected]" (note 1.2.0). There is an error when running the job: "Error: unknown flag: --region". When I use "1.2.1", it does not give that error. It uses the "regions" flag in 1.2.1, which results in it not throwing an error.

@WilliamFernsV3
Copy link
Author

It is also worth noting that when your organization name have capital letters (probably the same if the repo is on your own account), it says that the app name must only be lowercase, numbers and dashes.

Here is the logs:

+ flyctl launch --no-deploy --copy-config --name pr-6-Agnostic-Software-stoppmo-backend --image  --region jnb --org stoppmo
An existing fly.toml file was found for app stoppmo-backend
Scanning source code
Detected a Dockerfile app
Error: app name must consist of only lowercase letters, numbers, and dashes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant