Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Runs OneSDK on Node 19.
Found bug in mockttp, where connection header is deleted and client doesn't know how to behave.
I choose to use
Connection: close
because with keep-alive, I would need to set alsoKeep-Alive: timeout=5
. And I hope I will be able to fix mockttp eventually, so this can be reverted.Motivation and Context
I want to have OneSDK tested on all supported Node.js versions
Types of changes
Checklist: