Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Node 19 to CI Tests #320

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add Node 19 to CI Tests #320

wants to merge 3 commits into from

Conversation

freaz
Copy link
Member

@freaz freaz commented Jan 12, 2023

Description

Runs OneSDK on Node 19.

Found bug in mockttp, where connection header is deleted and client doesn't know how to behave.

I choose to use Connection: close because with keep-alive, I would need to set also Keep-Alive: timeout=5. And I hope I will be able to fix mockttp eventually, so this can be reverted.

Motivation and Context

I want to have OneSDK tested on all supported Node.js versions

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have updated the documentation accordingly. If you are changing code related to user secrets you need to really make sure that security documentation is correct.
  • I have read the CONTRIBUTING document.
  • I haven't repeated the code. (DRY)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Contributor

@TheEdward162 TheEdward162 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder how this will turn out with the next LTS, somebody ought to be running into the same trouble.

@freaz freaz changed the base branch from dev to main February 8, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants