Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: separate envoy lds configs for self-hosting and supabase use-cases #1325

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

hf
Copy link
Contributor

@hf hf commented Nov 19, 2024

Separates Envoy's lds.yaml file for two different use cases: self-hosting and for Supabase internal use.

For self-hosting:

  • File remains to be called lds.yaml
  • Includes only self-hosing concepts such as fixed API keys
  • Control which lds.yaml file is used with the envoy_lds Docker build arg

For Supabase:

  • File is called lds.supabase.yaml
  • Is replaced into /etc/envoy/lds.yaml with an Ansible task part of ansible/tasks/setup-supabase-internal.yml
  • For Fly, replaced using the envoy_lds Docker build arg
  • In follow up PR it will contain an origin protection key which is not something available in the Docker image for self-hosting
  • Future: once origin protection keys are rolled out and new API keys are in place, Envoy will no longer check any API keys

@hf hf requested a review from a team as a code owner November 19, 2024 13:45
@@ -0,0 +1,436 @@
resources:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A verbatim copy of lds.yaml

@hf
Copy link
Contributor Author

hf commented Nov 20, 2024

Will bump versions after this is approved.

@hf hf force-pushed the hf/envoy-separate-lds branch from b6500c3 to 46b0ee6 Compare November 20, 2024 13:12
@hf hf force-pushed the hf/envoy-separate-lds branch from 46b0ee6 to ee2bc63 Compare November 20, 2024 13:34
ansible/vars.yml Show resolved Hide resolved
Copy link
Contributor

@samrose samrose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to merge

@hf hf merged commit dd307fb into develop Nov 20, 2024
10 checks passed
@hf hf deleted the hf/envoy-separate-lds branch November 20, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants