Ruby 3.2 compatibility #616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Redwood module was leaking into other tests via the wrongly placed `include` in test/test_header_parsing.rb. Without this fix, running `rake test TEST=test/integration/test_maildir.rb` or `rake test TEST=test/integration/test_mbox.rb` would fail because Redwood was not being included in that case. Fix the tests to include Redwood into each individual class where it's needed, and avoid leaking into other tests.
This only matters in the test suite, which is the only time that Index is constructed pointing to a custom directory (the test's temp dir). Fixes test/integration/test_mbox.rb and test/integration/test_maildir.rb to not try reading my sources from ~/.sup during test execution.
Since Ruby 3.2, the URI#host method returns empty string rather than nil if the URI does not have a host component (like maildir:///blah). Apparently for some kind of security reasons, see: ruby/ruby@dd5118f
This is to get ruby_3_2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.