Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model name in XML has no corresponding field in spreadsheet #24

Open
altendky opened this issue Jun 13, 2017 · 1 comment
Open

Model name in XML has no corresponding field in spreadsheet #24

altendky opened this issue Jun 13, 2017 · 1 comment

Comments

@altendky
Copy link
Contributor

A model's 'name' shows up three times in the XML file (see below). In the case of model 103 there are two different values between the three locations. The spreadsheet has the name once on the index page and again as the ID point's label. In both cases in the spreadsheet it is 'Inverter (Three Phase)'. It would be nice to have the spreadsheet include the <model name="..."> version (simply "inverter") for reference since that is what is used by the sunspec/pysunspec library.

Other values address this by having the 'computer name' in the 'Name' column and the 'human name' in the 'Label' column, but since the 'Name' for the model must be 'ID' we are left with this missing piece.

https://github.com/sunspec/models/blob/94a0d35a2db8f011f88d1fa62424046bc11709b8/smdx/smdx_00103.xml

  <!-- 103: inverter -->
  <model id="103" len="50" name="inverter">
  <strings id="103" locale="en">
    <model>
      <label>Inverter (Three Phase)</label>
@ghost
Copy link

ghost commented Aug 6, 2019

Currently reviewing model naming

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant