Fixing Fermi plot_detector_sun_angles #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…egend location as well.
nabobalis
approved these changes
Aug 22, 2024
|
We have no unit tests for any of this. That will have to come in a new PR when I add support for figure tests. |
|
Thanks for the fix @aringlis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function
plot_detector_sun_angleswas broken, due to the formatting of the time axis. This was reported in #71.This PR proposes a fix by reformatting the time axis as datetimes, which matplotlib accepts. Also tidied up the location of the legend to be outside the plotting area.
Fixes #71