Skip to content
This repository has been archived by the owner on Jan 11, 2021. It is now read-only.

Apply clippy suggestions #144

Open
gnieto opened this issue Aug 9, 2018 · 3 comments
Open

Apply clippy suggestions #144

gnieto opened this issue Aug 9, 2018 · 3 comments

Comments

@gnieto
Copy link
Contributor

gnieto commented Aug 9, 2018

I've ran clippy on the project and it reports some issues. I think it would be nice to apply the suggestions and even ran clippy on CI/Travis.

What do you think?

@sunchao
Copy link
Owner

sunchao commented Aug 10, 2018

+1. I think this will be a good thing to add.

@sadikovi
Copy link
Collaborator

Can you be clear if those are issues or suggestions?

@sadikovi
Copy link
Collaborator

sadikovi commented Aug 10, 2018

I just ran it, it reports a bunch of warnings and errors, and a lot of them are false positives. I am not sure we want to do it automatically on every build, but doing it once to fix some of the issues could be beneficial, similar to what we did with style. Cheers!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants