Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up events #21

Open
suluke opened this issue Jan 29, 2016 · 0 comments
Open

Clean up events #21

suluke opened this issue Jan 29, 2016 · 0 comments

Comments

@suluke
Copy link
Owner

suluke commented Jan 29, 2016

We introduced the datepicker-change-incomplete event, which is only used by top-bar so far. This overlaps with the datepicker-first-date-selected event.

The semantics of the events should be specified, i.e.:

  1. datepicker-change indicates that the picker has either all or none of the required dates set.
  2. datepicker-first-date-selected is only triggered in date_range_ mode (not singledate) and indicates that the picker is currently in a whacky/illegal state where the user is expected to select the second state.

The triggerHasChanged method should take care of triggering all of the above events.
The invalidate method and checkSelectionValid methods need to be checked if there is code that is not required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant