Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About the code #11

Open
RuoyuChen10 opened this issue Jun 25, 2024 · 3 comments
Open

About the code #11

RuoyuChen10 opened this issue Jun 25, 2024 · 3 comments

Comments

@RuoyuChen10
Copy link

Hi, I would like to ask if your code is already runnable. The examples in the jupyter notebook from a year ago seem to have many bugs. Thanks for your nice work!

@JensRahnfeld
Copy link

JensRahnfeld commented Jul 19, 2024

Dear @chanwkimlab & @iancovert ,

thank you very much for the great work. It really helped me in my research project back then. As a token of gratitude, i would like to contribute to the repository through this PR. It mainly

  • updates the benchmarking notebook which enabled me to reproduce your results on ImageNette and Pets
  • cleans up some code to improve readability.

@RuoyuChen10 i hope this helps.

Best,
Jens

@chanwkimlab
Copy link
Collaborator

Thanks you for your great interest in our work! I did not encounter significant bugs while using the benchmarking notebook back then, but I believe there could be some minor unknown bugs as I haven't tested it rigorously across multiple environments. Thank you so much, Jens, for the pull request with cleaned-up code. I'll review this and update accordingly.

@RuoyuChen10
Copy link
Author

Thanks you for your great interest in our work! I did not encounter significant bugs while using the benchmarking notebook back then, but I believe there could be some minor unknown bugs as I haven't tested it rigorously across multiple environments. Thank you so much, Jens, for the pull request with cleaned-up code. I'll review this and update accordingly.

Can you offer an example with CLIP? I hope that the comparison of our approach with yours, which will be performed on multimodal VIT, will also help to publicize your work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants