add leader election retry #66
+60
−39
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,6 +10,7 @@ import ( | |
| "k8s.io/client-go/kubernetes" | ||
| "k8s.io/client-go/tools/leaderelection" | ||
| "k8s.io/client-go/tools/leaderelection/resourcelock" | ||
| "k8s.io/client-go/util/flowcontrol" | ||
| ) | ||
|
|
||
| func NewElection(clientset kubernetes.Interface, id, namespace string) *Election { | ||
|
|
@@ -63,5 +64,27 @@ type Election struct { | |
| } | ||
|
|
||
| func (le *Election) Start(ctx context.Context) { | ||
| backoff := flowcontrol.NewBackOff(1*time.Second, 15*time.Second) | ||
| const backoffID = "lingo-leader-election" | ||
| retryCount := 0 | ||
| for { | ||
| select { | ||
| case <-ctx.Done(): | ||
| return | ||
| default: | ||
| if retryCount > 0 { | ||
| backoff.Next(backoffID, backoff.Clock.Now()) | ||
| delay := backoff.Get(backoffID) | ||
| log.Printf("Leader election failed, retrying in %v. RetryCount: %v", delay, retryCount+1) | ||
| select { | ||
| case <-time.After(delay): | ||
| case <-ctx.Done(): | ||
| return | ||
| } | ||
| } | ||
| log.Printf("Starting leader election process. RetryCount: %v", retryCount+1) | ||
| leaderelection.RunOrDie(ctx, le.config) | ||
|
There was a problem hiding this comment. Is the idea that RunOrDie eventually exits if it loses connection to the API Server? There was a problem hiding this comment. That's exactly what seems to end up happening. This Kong PR has more details: Kong/kubernetes-ingress-controller#578 There was a problem hiding this comment. I double confirmed this by checking the logs and seeing how often it had to retry (re-run RunOrDie) when the apiserver is down for ~2 minutes |
||
| retryCount++ | ||
| } | ||
| } | ||
samos123 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat, I didnt know about this library