evm: add tx.authorizationList field #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmcgroul
commented
Nov 16, 2024
| @@ -35,6 +35,16 @@ export interface EvmTransaction extends _EvmTx, _EvmTxReceipt { | |||
| } | |||
|
|
|||
|
|
|||
| export interface Authorization { | |||
There was a problem hiding this comment.
@eldargab do we need Evm prefix as for other entities?
There was a problem hiding this comment.
Prefix might be helpful, but don't forget to re-export Authorization in a prefix-less form.
I'm afraid Authorization is too ambiguous, though. May be call it like EIP7702Authorization?
tmcgroul
commented
Nov 16, 2024
| @@ -64,6 +74,7 @@ export function getTxProps(fields: FieldSelection['transaction'], forArchive: bo | |||
| s: withSentinel('Transaction.s', '0x', BYTES), | |||
| yParity: option(natural), | |||
| chainId: option(natural), | |||
| authorizationList: option(array(Authorization)), | |||
There was a problem hiding this comment.
@eldargab do we need ability to select each field manually or it's fine and we can load the whole array of structures?
There was a problem hiding this comment.
Let's expose it as a whole.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.