Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

solana: add instructionIndex to instruction #349

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

solana: add instructionIndex to instruction #349

wants to merge 2 commits into from

Conversation

tmcgroul
Copy link
Contributor

No description provided.

@tmcgroul
Copy link
Contributor Author

@eldargab should innerInstructionIndex be undefined for primary instructions or -1?

@eldargab
Copy link
Collaborator

eldargab commented Nov 1, 2024

I think, it should be undefined.

eldargab
eldargab requested changes Nov 1, 2024
View reviewed changes
solana/solana-normalization/src/mapping.ts
let i: Instruction = {
innerInstructionIndex: this.innerPos,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, it is better to set it directly, rather than recalculating it here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you mean outside of push method? it seems that inner instructions can be created in several methods so it's hard to track them 🤷‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eldargab eldargab eldargab requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmcgroul @eldargab