Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor p2p request client #132

Open
kalabukdima opened this issue Nov 28, 2024 · 0 comments
Open

Refactor p2p request client #132

kalabukdima opened this issue Nov 28, 2024 · 0 comments
Assignees

Comments

@kalabukdima
Copy link
Collaborator

This code is too hard to understand and may contain bugs or memory leaks.
Another issue is that the interface doesn't allow backpressure — if the internal buffer gets filled, it still allows to send new queries, but immediately drops them and emits a corresponding event. Instead it should allow to block the sending side until the query may be sent.

@kalabukdima kalabukdima self-assigned this Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant