Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gateway query sending in transport lib #118

Open
kalabukdima opened this issue Sep 30, 2024 · 0 comments
Open

Fix gateway query sending in transport lib #118

kalabukdima opened this issue Sep 30, 2024 · 0 comments
Assignees

Comments

@kalabukdima
Copy link
Collaborator

kalabukdima commented Sep 30, 2024

https://github.com/subsquid/sqd-network/blob/main/crates/transport/src/actors/gateway.rs#L257

Queries are put to the queue and then moved to another internal queue. If this internal queue is full, the query is just dropped, and there is no way to know about it on the caller side.

  1. Introduce some kind of backpressure and ensure that "Outbound message queue full" errors don't occur anymore.
  2. Sanitize interface for send_query — return channel and hide the details about id matching.
@kalabukdima kalabukdima self-assigned this Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant