Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diagnostics across files within a project #73

Open
agreco opened this issue Jul 21, 2021 · 13 comments
Open

Diagnostics across files within a project #73

agreco opened this issue Jul 21, 2021 · 13 comments

Comments

@agreco
Copy link

agreco commented Jul 21, 2021

Hey,

I've been using this LSP server with a lot of success on my projects.

There is one feature I think is still missing, which is the ability to use the LSP diagnostics panel to show all errors/warnings across files within a project. To determine if a project has any issues I have to compile the project from outside ST.

I raised the same issue here: sublimelsp/LSP#1803, and the advice was that type of feature would need to be handled by the LSP server in question.

Hope this is enough info.

Cheers

@rchl
Copy link
Member

rchl commented Aug 23, 2021

The server itself is at https://github.com/typescript-language-server/typescript-language-server. This package is just a simple wrapper to get it running.

That said, I don't really think https://github.com/typescript-language-server/typescript-language-server can support it. It depends on typescript compiler itself (tsserver) and I don't see this being an option there.

@rchl
Copy link
Member

rchl commented Aug 23, 2021

In any case, feel free to raise this at https://github.com/typescript-language-server/typescript-language-server.

Even though I'm one of the maintainers of that server, I'm not sure if that's possible. Maybe someone else will be able to chime in there.

@rchl rchl closed this as completed Aug 23, 2021
@agreco
Copy link
Author

agreco commented Aug 24, 2021

In any case, feel free to raise this at https://github.com/typescript-language-server/typescript-language-server.

Even though I'm one of the maintainers of that server, I'm not sure if that's possible. Maybe someone else will be able to chime in there.

Sure thing, thanks for the reply.

@rchl
Copy link
Member

rchl commented Sep 13, 2021

As I've eventually realized in the linked issue, this is a feature that fits this package more than the actual server.

@agreco
Copy link
Author

agreco commented Sep 13, 2021

Cool! Look forward to some more discussions :)

@agreco agreco closed this as completed Sep 13, 2021
@agreco agreco reopened this Sep 13, 2021
@agreco
Copy link
Author

agreco commented Sep 13, 2021

Opps! just closed this ticket by accident. Apologies!!

@rwols
Copy link
Member

rwols commented Sep 14, 2021

Sounds like a job for a Build System? https://www.sublimetext.com/docs/build_systems.html

@rchl
Copy link
Member

rchl commented Sep 16, 2021

That would probably not provide a great experience since it would pop up the panel on starting each build rather than only showing a panel on there being a build errors.

So probably it would have to be some custom command similar to an example in the documentation. And not necessarily tied to the build system.

@predragnikolic
Copy link
Member

Related issue sublimelsp/LSP#1868

@agreco
Copy link
Author

agreco commented Nov 17, 2021

Related issue sublimelsp/LSP#1868

That issue is quite interesting, it seems that the PR which was created off the back of that has been merged and should provide diagnostics across a project. I've tried updating my packages but I'm not experiencing this change, can anyone else confirm?

@rchl
Copy link
Member

rchl commented Nov 17, 2021

That's not gonna help here as the server doesn't report diagnostics for the whole project in the first place.

@agreco
Copy link
Author

agreco commented Nov 23, 2021

That's not gonna help here as the server doesn't report diagnostics for the whole project in the first place.

Ah of course! Apologies for any confusion caused.

@rchl rchl mentioned this issue Nov 14, 2022
@JGJP
Copy link

JGJP commented Nov 25, 2022

tsc --no-emit reports type errors across the project, would it be possible to get these kinds of results through LSP and be able to navigate to each issue or apply code actions to them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants