Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signals: New link and sender domains #818

Merged
merged 3 commits into from
Oct 3, 2023
Merged

Signals: New link and sender domains #818

merged 3 commits into from
Oct 3, 2023

Conversation

jkamdjou
Copy link
Member

No description provided.

@jkamdjou jkamdjou requested review from bfilar and a team September 24, 2023 22:42
@morriscode
Copy link
Member

morriscode commented Sep 24, 2023

Lgtm! Is there any particular reason to be specific rather than just returning the days_old int and evaluating that way?

Like why not just return the float, and sort it in hydra?

and map(body.links, beta.whois(.href_url.domain).days_old)
and map([sender.email.domain], beta.whois(.).days_old)

Nevermind @bfilar told me why what I'm saying isn't great.

@rw-access
Copy link
Contributor

🚢

@bfilar bfilar enabled auto-merge (squash) October 3, 2023 20:06
@bfilar bfilar merged commit 19e2874 into main Oct 3, 2023
2 checks passed
@bfilar bfilar deleted the josh.signals_whois branch October 3, 2023 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants