Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update attachment_html_smuggling_unescape.yml #816

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Conversation

morriscode
Copy link
Member

Depending on how the HTML is structured javascript identifiers never populates and this is present in strings only. Updating to accommodate.

Depending on how the HTML is structured javascript identifiers never populates and this is present in strings only. Updating to accommodate.
@morriscode morriscode requested a review from a team September 22, 2023 20:11
@jkamdjou
Copy link
Member

@morriscode failing Mimic FYI

@morriscode
Copy link
Member Author

@morriscode failing Mimic FYI

that makes 0 sense, the existing logic is still there. Will review tho

@morriscode
Copy link
Member Author

morriscode commented Sep 22, 2023

These regressions don't have any attachments, see notes and links to notion. I suspect they regressed for some other reason, however all of them are still firing rules in our platform, mostly BEC related rules. This change is safe to merge as the original matching criteria was never changed nor deleted, only expanded upon.

cc @jkamdjou

notion.so/EML-29740 - This email has 0 attachments. Regressing on it makes no sense. The rule would've never fired on this.
notion.so/EML-25460 - This email has 0 attachments. Regressing on it makes no sense. The rule would've never fired on this.
notion.so/EML-24589 - This email has 0 attachments. Regressing on it makes no sense. The rule would've never fired on this.
notion.so/EML-2396 - This email has 0 attachments. Regressing on it makes no sense. The rule would've never fired on this.
notion.so/EML-4236 - This email has 0 attachments. Regressing on it makes no sense. The rule would've never fired on this.
notion.so/EML-18055 - This email has 0 attachments. Regressing on it makes no sense. The rule would've never fired on this.
notion.so/EML-16923 - - This email has 0 attachments. Regressing on it makes no sense. The rule would've never fired on this.

@morriscode morriscode merged commit 7a7921a into main Sep 22, 2023
3 of 4 checks passed
@morriscode morriscode deleted the morriscode-patch-2 branch September 22, 2023 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants