Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Rule: attachment_docusign_image_suspicious_links.yml #761

Merged
merged 5 commits into from
Oct 3, 2023

Conversation

aidenmitchell
Copy link
Member

@aidenmitchell aidenmitchell commented Sep 1, 2023

FTS fails when internal senders are spoofed, this should fix that.

FTS fails when internal senders are spoofed, this should fix this.
@aidenmitchell aidenmitchell requested a review from a team September 1, 2023 16:17
morriscode
morriscode previously approved these changes Sep 8, 2023
Copy link
Member

@morriscode morriscode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gorgeous

@morriscode
Copy link
Member

/update-test-rules

github-actions bot pushed a commit that referenced this pull request Sep 8, 2023
Updating Rule: attachment_docusign_image_suspicious_links.yml by @aidenmitchell
#761
Source SHA 6513d69
Triggered by @morriscode
@morriscode morriscode self-requested a review September 8, 2023 03:00
@morriscode morriscode dismissed their stale review September 8, 2023 03:00

A bit premature, have some concerns about internal senders with bad/spf dkim records

@morriscode morriscode enabled auto-merge (squash) October 3, 2023 21:00
@morriscode morriscode merged commit 254c6cb into sublime-security:main Oct 3, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants