Updating Rule: re-naming bit.ly rule + adding flagged detection #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morriscode
approved these changes
Oct 26, 2023
|
cc @aidenmitchell conflicts ahoy! |
auto-merge was automatically disabled
October 26, 2023 14:07
Head branch was pushed to by a user without write access
auto-merge was automatically disabled
October 26, 2023 14:07
Pull request was closed
aidenmitchell
force-pushed
the
aidenmitchell-patch-1-2
branch
from
0609b5f to
aaffe1b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out bit.ly has 2 kinds of gating, complete block (which is what we were detecting before), and a warning page that lets you continue. Adding detection for the latter.
We could also make a new 2nd rule if we want to differentiate in the UI, open to that.
Block page:
Warning page:
