Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

standardize docusign auth check #2090

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

standardize docusign auth check #2090

wants to merge 5 commits into from

Conversation

zoomequipd
Copy link
Member

@zoomequipd zoomequipd commented Nov 5, 2024 •
edited
Loading

@zoomequipd zoomequipd requested a review from a team as a code owner November 5, 2024 17:35
@zoomequipd zoomequipd added the review-needed Indicates that a PR is waiting for review label Nov 5, 2024
@zoomequipd
Copy link
Member Author

This looses up the docusign auth detection

@zoomequipd zoomequipd mentioned this pull request Nov 5, 2024
Merged
@aidenmitchell
Copy link
Member

Looks like docusign.com was pulled out of one rule, and is missing from the other 2. Is that intentional?

morriscode
morriscode previously approved these changes Dec 23, 2024
View reviewed changes
@morriscode morriscode dismissed their stale review December 23, 2024 23:57

premature

@zoomequipd
Copy link
Member Author

Looks like docusign.com was pulled out of one rule, and is missing from the other 2. Is that intentional?

Yeah, docusign.com appears to be used more for corporate communications than product communications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morriscode morriscode morriscode left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
review-needed Indicates that a PR is waiting for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zoomequipd @aidenmitchell @morriscode