Collect mql-mimic-exempt Comments & Sent to MQL Mimic #1199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/mql-mimic-exempt |
cameron-dunn-sublime
changed the title
| @@ -39,8 +39,8 @@ jobs: | |||
| uses: actions/checkout@v3 | |||
| if: github.event_name == 'issue_comment' | |||
| with: | |||
| repository: ${{ steps.comment-branch.outputs.head_owner }}/${{ steps.comment-branch.outputs.head_repo }} | |||
| ref: ${{ steps.comment-branch.outputs.head_ref }} | |||
| repository: ${{ steps.comment_branch.outputs.head_owner }}/${{ steps.comment_branch.outputs.head_repo }} | |||
There was a problem hiding this comment.
Another follow up from #1198
Still not seeing the comment triggering behavior work as expected, and hopefully this is the last issue. I can't test this until it's merged to main, so no guarantees (but we have a near identical workflow for test rules, so it should be close if this doesn't fix it).
| @@ -45,12 +45,12 @@ jobs: | |||
|
|
|||
| - name: Get PR branch | |||
| uses: alessbell/[email protected] # Fork of xt0rted/pull-request-comment-branch, see https://github.com/xt0rted/pull-request-comment-branch/issues/322 | |||
| id: comment-branch | |||
| id: comment_branch | |||
There was a problem hiding this comment.
Changed it here for consistency. _ preferred so that it's considered a single word in most contexts.
|
This looks great! I'm excited to hear how the testing goes. |
morriscode
approved these changes
Dec 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With some luck, this will be the last change on the
sublime-rulesside to support a system where we can make exceptions to MQL Mimic by commenting:That would cause 12234 & 556 to be skipped in the test suite. This will allow bypassing when the team decides that a apparent regression is actually a good thing, e.g. the EML shouldn't have matched the rule in the first place.
The behavior is that:
/mql-mimic-exemptis added by an org member, the test suite will be re-triggered and should update the existing checks.main)/mql-mimic-exempt, and any numbers that appear on the same line are considered./mql-mimic-exempt :123;456/mql-mimic-exempt: 123 456/mql-mimic-exempt: 123,#456/mql-mimic-exempt 123/456#is ignored,,,;,:,/and any whitespace are allowed as separatorsDownstream support in MQL Mimic has not been added yet! It's mostly done, but not merged.
Tested via #1202, resulting trigger request body is
{"branch":"cd.test-2","repo":"sublime-security/sublime-rules","token":"***","sha":"de8c38262ed8cda7c55a087c9d0e802f7d462458","only_rule_ids":"2fc36c6d-86a2-5b12-b5a4-5d8744858381","skip_eml_ids":"123 456 789 123 456 789 444"}which is correct for the comments I've put on that PR.