From 0500de6a8e0dcfa9c72c91e9b3718105e92780ce Mon Sep 17 00:00:00 2001 From: Cameron Dunn Date: Tue, 24 Oct 2023 21:19:12 -0700 Subject: [PATCH] clean/fix --- .github/workflows/rule-validate.yml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/rule-validate.yml b/.github/workflows/rule-validate.yml index 64d8f08bfc0..47a8ca549bb 100644 --- a/.github/workflows/rule-validate.yml +++ b/.github/workflows/rule-validate.yml @@ -139,10 +139,9 @@ jobs: id: find_ids run: | for file in detection-rules/*.yml; do - echo "$file was changed" rule_id=$(yq '.id' $file) - if [ ${{ steps.get_base_ref.outputs.run_all != 'true' }} ]; then + if [ ${{ steps.get_base_ref.outputs.run_all }} = 'true']; then altered_rule_ids=$(echo "$rule_id"" ""$altered_rule_ids") continue fi @@ -150,7 +149,6 @@ jobs: echo "$file has rule ID $rule_id" new_source=$(yq '.source' "$file") old_source=$(yq '.source' "sr-main/detection-rules/$rule_id.yml" || echo '') - echo $old_source # We only need to care when rule source is changed. This will handle renames, tag changes, etc. if [ "$new_source" != "$old_source" ]; then