Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basics of prompt modification in popup - #22 #32

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ryan-at-kettle
Copy link

The attached code enables basic prompt modification when running the extension.

@ryan-at-kettle
Copy link
Author

This is a very basic version of prompt modification. Next potential steps after merging:

  • Allow configuration of default prompt parts in the extension configuration (this would enable language localization by users).
  • Allow specifying which prompt parts can be modified in the live modification popup in the settings panel.
  • Allow toggling of live modification and automatic runs in the popup in the settings panel.
  • Allow configurable variables in live and settings for things like language, the programming language version, and so on.

@ryan-at-kettle
Copy link
Author

It looks like the last prompt, "All code changes have been provided. Please provide me with your code review based on all the changes, context & title provided," is nudging the output more than expected.

This needs more work. I will be updating this again later.

@ryan-at-kettle
Copy link
Author

Okay, this has been updated to allow the additional prompts and toggling of prompt inputs. I'm comfortable merging this now. Note that this does not maintain a prompt history and may frustrate users.

@nickveenhof
Copy link
Collaborator

Cool. Let me test it

@nickveenhof
Copy link
Collaborator

When pressing run or run again in the modal, it does not switch back to the output of ChatGPT
image

Personally I'd prefer these prompt to be in the same spot as the rest of the settings. Otoh I like the easy of access to those prompts. Another recommendation would be a pencil item in the prompts tab, some visual cue or a description so that it is clear that these prompts can be edited.

Additionally, it's not quite clear where it adds specific context from the PR/MR. I'd prefer to keep the replacement tokens in the text so that people can also play with those positions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants