Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug? should this .append be a .push #2543

Open
cobbzilla opened this issue Jun 2, 2024 · 1 comment · May be fixed by #2906
Open

bug? should this .append be a .push #2543

cobbzilla opened this issue Jun 2, 2024 · 1 comment · May be fixed by #2906

Comments

@cobbzilla
Copy link

I think this line would break if the if (error) condition were true, because JS arrays don't have an .append method.

My IDE was complaining until I changed it.

@hibariya
Copy link
Collaborator

Right, this causes an error like below.

TypeError: messages.value.append is not a function

We should use push instead of it like L30 of the same file.

messages.value.push(`Payment ${paymentIntent.status}: ${paymentIntent.id}`)

hibariya added a commit that referenced this issue Nov 10, 2024
@hibariya hibariya linked a pull request Nov 10, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants
@hibariya @cobbzilla and others