Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map Maintenance: Handling of fixme=name and suspicious combinations of name=*+noname=yes #5934

Open
kmpoppe opened this issue Sep 29, 2024 Discussed in #5928 · 2 comments
Assignees

Comments

@kmpoppe
Copy link
Collaborator

kmpoppe commented Sep 29, 2024

Discussed in #5928

Originally posted by kmpoppe September 26, 2024

Situation

There are currently ~160k objects tagged with fixme=name.

Understandably, SC currently ignores fixme tags completely - IMHO most values of that key would be impossible to survey without deeper investigation.

Yet, fixme=name seems like a very straight-forward request: "I (the last mapper) was unable to determine what the name of this feature is, please help out".

Proposal

I therefore would suggest for SC to work the following way:

a) remove fixme=name (if present) when the user answers quests/road_name or quests/place_name with either a real name or noname=yes (because otherwise, things like this (noname=yes set, fixme=name persited) or this (name set, fixme=name persisted) happen)

b) the aforementioned quests should force a survey of the name when a fixme=name is older than one year to get rid of it, because all viable answer paths from there (name=*, noname=yes or changing the type of road that doesn't get asked for a name again) lead to a situation where the fixme is no longer relevant.

c) FIXME=name, Fixme=name, fixme=name?, Fixme=Name, ... could be handled the same way.

SCEE

I do not think that this option should only be something relevant for SCEE, because the handling is purely under to hood and there's no expert knowledge necessary to answer those already existing quests.

AE

An automated edit of things that are "clear cut" as proposed by @matkoniecz is planned, SC's tagging cleanup is nevertheless needed for remaining instances of fixme occurances.

@kmpoppe kmpoppe self-assigned this Sep 29, 2024
@westnordost
Copy link
Member

Why not always ask for the name if fixme=name is set?

A note regarding implementation: What if the name is already (partly) set? I am thinking about multilingual names. The previous name(s) should also be shown in the form, if they aren't, yet.

@kmpoppe
Copy link
Collaborator Author

kmpoppe commented Oct 2, 2024

Why not always ask for the name if fixme=name is set?

Makes sense

A note regarding implementation: What if the name is already (partly) set? I am thinking about multilingual names. The previous name(s) should also be shown in the form, if they aren't, yet.

Will have to check how that works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants