Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MediaStreamRecorder in NPM is not a latest version on this Github #154

Open
hanguyen-it opened this issue Dec 18, 2017 · 1 comment
Open

Comments

@hanguyen-it
Copy link

Hello Muaz Khan,

Your MediaStreamRecorder is very excellent and I very love it. However, it seem the latest source of MediaStreamRecorder is not yet published to NPM. Would you mind publishing it? Thank you very much.

Thanks.

@hanguyen-it hanguyen-it changed the title Packages are published to NPM is not a latest version on Github MediaStreamRecorder in NPM is not a latest version on this Github Dec 18, 2017
@ykmo-VIRNECT
Copy link

ykmo-VIRNECT commented May 25, 2020

Well, I facing Similar problem.

For example,
MultiStreamRecorder require two parameters arrayOfMediaStreams and options in github ver

//git hub version
function MultiStreamRecorder(arrayOfMediaStreams, options) {
    arrayOfMediaStreams = arrayOfMediaStreams || [];

    if (arrayOfMediaStreams instanceof MediaStream) {
        arrayOfMediaStreams = [arrayOfMediaStreams];
    }
  // ...
}

But, in npm ver require only mediaStream

//npm version
function MultiStreamRecorder(mediaStream) {
    if (!mediaStream) {
        throw 'MediaStream is mandatory.';
    }

    var self = this;
    var isMediaRecorder = isMediaRecorderCompatible();

    this.stream = mediaStream;
   //...
}

I think npm version is not updated properly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants