From 4afa294f48c551d7fde56f3897de7e7a596d5002 Mon Sep 17 00:00:00 2001
From: Nikos Dimitrakopoulos <nikosd@euruko2013.org>
Date: Sun, 21 Apr 2013 21:25:52 +0300
Subject: [PATCH] Make sure the dashboard integration test won't break in two
 days when phase changes. Refs #15.

---
 test/integration/dashboard_test.rb | 237 +++++++++++++++--------------
 1 file changed, 120 insertions(+), 117 deletions(-)

diff --git a/test/integration/dashboard_test.rb b/test/integration/dashboard_test.rb
index 6b969e6..0766b9e 100644
--- a/test/integration/dashboard_test.rb
+++ b/test/integration/dashboard_test.rb
@@ -1,187 +1,190 @@
 require "test_helper"
 
 class DashboardTest < IntegrationTestCase
-
-  context "Given a bunch of proposals with varying amounts of feedback" do
+  context "During phase one" do
     setup do
-      @me = FactoryGirl.create(:user)
+      Phase.stubs(:current).returns(Phase::ONE)
+    end
 
-      @proposal1 = FactoryGirl.create(:proposal)
-      @proposal2 = FactoryGirl.create(:proposal)
-      @proposal3 = FactoryGirl.create(:proposal)
+    context "given a bunch of proposals with varying amounts of feedback" do
+      setup do
+        @me = FactoryGirl.create(:user)
 
-      @withdrawn_proposal = FactoryGirl.create(:proposal, withdrawn: true)
+        @proposal1 = FactoryGirl.create(:proposal)
+        @proposal2 = FactoryGirl.create(:proposal)
+        @proposal3 = FactoryGirl.create(:proposal)
 
-      @my_proposal = FactoryGirl.create(:proposal, :proposer => @me)
+        @withdrawn_proposal = FactoryGirl.create(:proposal, withdrawn: true)
 
-      FactoryGirl.create(:suggestion, :proposal => @proposal2)
-      FactoryGirl.create(:suggestion, :proposal => @proposal2)
-      FactoryGirl.create(:suggestion, :proposal => @proposal2)
+        @my_proposal = FactoryGirl.create(:proposal, :proposer => @me)
 
-      FactoryGirl.create(:suggestion, :proposal => @proposal1)
-    end
-
-    context "When I visit my dashboard" do
-      setup do
-        sign_in @me
-        visit "/dashboard"
-      end
+        FactoryGirl.create(:suggestion, :proposal => @proposal2)
+        FactoryGirl.create(:suggestion, :proposal => @proposal2)
+        FactoryGirl.create(:suggestion, :proposal => @proposal2)
 
-      should "see a list of proposals I made" do
-        within('#your-proposals') do
-          assert page.has_content?(@my_proposal.title), "proposal was missing"
-        end
+        FactoryGirl.create(:suggestion, :proposal => @proposal1)
       end
 
-      context "and some new suggestions have been made for one of my proposals" do
+      context "When I visit my dashboard" do
         setup do
-          Timecop.travel 5.minutes.from_now
-          FactoryGirl.create(:suggestion, :proposal => @my_proposal)
-          FactoryGirl.create(:suggestion, :proposal => @my_proposal, :author => @me)
-          Timecop.travel 5.minutes.from_now
-          FactoryGirl.create(:suggestion, :proposal => @my_proposal)
-          FactoryGirl.create(:suggestion, :proposal => @my_proposal)
+          sign_in @me
           visit "/dashboard"
         end
 
-        should "show in the list that there are new suggestions" do
-          within_object("#your-proposals", @my_proposal) do
-            assert page.has_content?("2 new suggestions"), "proposal should indicate it has new suggestions"
+        should "see a list of proposals I made" do
+          within('#your-proposals') do
+            assert page.has_content?(@my_proposal.title), "proposal was missing"
           end
         end
 
-        context "but I've updated my proposal since" do
+        context "and some new suggestions have been made for one of my proposals" do
           setup do
             Timecop.travel 5.minutes.from_now
-            @my_proposal.description = "Blah blah blah"
-            @my_proposal.save!
+            FactoryGirl.create(:suggestion, :proposal => @my_proposal)
+            FactoryGirl.create(:suggestion, :proposal => @my_proposal, :author => @me)
+            Timecop.travel 5.minutes.from_now
+            FactoryGirl.create(:suggestion, :proposal => @my_proposal)
+            FactoryGirl.create(:suggestion, :proposal => @my_proposal)
             visit "/dashboard"
           end
 
-          should "show in the list that there are no new suggestions" do
+          should "show in the list that there are new suggestions" do
             within_object("#your-proposals", @my_proposal) do
-              assert !page.has_content?('new suggestions'), "proposal should not appear to have new suggestions"
+              assert page.has_content?("2 new suggestions"), "proposal should indicate it has new suggestions"
             end
           end
 
-          should "not show my proposal as changed" do
-            assert !page.has_css?("#things-have-changed"), "my proposal shouldn't be in the changed list"
-          end
-        end
+          context "but I've updated my proposal since" do
+            setup do
+              Timecop.travel 5.minutes.from_now
+              @my_proposal.description = "Blah blah blah"
+              @my_proposal.save!
+              visit "/dashboard"
+            end
 
-        context "but I've added a suggestion to my proposal since" do
-          setup do
-            Timecop.travel 5.minutes.from_now
-            FactoryGirl.create(:suggestion, :proposal => @my_proposal, :author => @me)
-            visit "/dashboard"
-          end
+            should "show in the list that there are no new suggestions" do
+              within_object("#your-proposals", @my_proposal) do
+                assert !page.has_content?('new suggestions'), "proposal should not appear to have new suggestions"
+              end
+            end
 
-          should "show in the list that there are no new suggestions" do
-            within_object("#your-proposals", @my_proposal) do
-              assert !page.has_content?('new suggestions'), "proposal should not appear to have new suggestions"
+            should "not show my proposal as changed" do
+              assert !page.has_css?("#things-have-changed"), "my proposal shouldn't be in the changed list"
             end
           end
-        end
-      end
 
-      should "see a list of talks that I haven't made any suggestions for" do
-        within('#you-should-look-at-these') do
-          assert page.has_content?(@proposal1.title), "proposal1 was missing"
-          assert page.has_content?(@proposal2.title), "proposal2 was missing"
-          assert page.has_content?(@proposal3.title), "proposal3 was missing"
-        end
-      end
+          context "but I've added a suggestion to my proposal since" do
+            setup do
+              Timecop.travel 5.minutes.from_now
+              FactoryGirl.create(:suggestion, :proposal => @my_proposal, :author => @me)
+              visit "/dashboard"
+            end
 
-      should 'not be prompted to look at a withdrawn proposal I haven\'t been involved with' do
-        within('#you-should-look-at-these') do
-          assert page.has_no_content?(@withdrawn_proposal.title), 'withdrawn_proposal is present, should be missing'
+            should "show in the list that there are no new suggestions" do
+              within_object("#your-proposals", @my_proposal) do
+                assert !page.has_content?('new suggestions'), "proposal should not appear to have new suggestions"
+              end
+            end
+          end
         end
-      end
 
-      should "link to individual suggestions" do
-        click_link @proposal1.title
-        assert_equal proposal_path(@proposal1), current_path
-      end
+        should "see a list of talks that I haven't made any suggestions for" do
+          within('#you-should-look-at-these') do
+            assert page.has_content?(@proposal1.title), "proposal1 was missing"
+            assert page.has_content?(@proposal2.title), "proposal2 was missing"
+            assert page.has_content?(@proposal3.title), "proposal3 was missing"
+          end
+        end
 
-      should "not see proposals I made in the list of talks requiring suggestions" do
-        within('#you-should-look-at-these') do
-          assert !page.has_content?(@my_proposal.title), "my proposal shouldn't be presented as requiring suggestions"
+        should 'not be prompted to look at a withdrawn proposal I haven\'t been involved with' do
+          within('#you-should-look-at-these') do
+            assert page.has_no_content?(@withdrawn_proposal.title), 'withdrawn_proposal is present, should be missing'
+          end
         end
-      end
 
-      context "And I have made suggestions for one of the talks" do
-        setup do
-          FactoryGirl.create(:suggestion, :proposal => @proposal1, :author => @me)
-          visit '/dashboard'
+        should "link to individual suggestions" do
+          click_link @proposal1.title
+          assert_equal proposal_path(@proposal1), current_path
         end
 
-        should "not see that talk in the list I haven't made suggestions for" do
+        should "not see proposals I made in the list of talks requiring suggestions" do
           within('#you-should-look-at-these') do
-            assert !page.has_content?(@proposal1.title), "proposal1 shouldn't be in the attention list"
+            assert !page.has_content?(@my_proposal.title), "my proposal shouldn't be presented as requiring suggestions"
           end
         end
 
-        context "and I have made suggestions for other talks with recent activity" do
+        context "And I have made suggestions for one of the talks" do
           setup do
-            FactoryGirl.create(:suggestion, :author => @me, :proposal => @proposal2)
-            Timecop.travel 10.minutes
-            @proposal2.update_attributes! :description => 'Now more interesting than before.'
+            FactoryGirl.create(:suggestion, :proposal => @proposal1, :author => @me)
             visit '/dashboard'
           end
 
-          should "not see that talk in my list of proposals with recent activity" do
-            within('#things-have-changed') do
-              assert !page.has_content?(@proposal1.title), "proposal1 shouldn't be in the changed list"
+          should "not see that talk in the list I haven't made suggestions for" do
+            within('#you-should-look-at-these') do
+              assert !page.has_content?(@proposal1.title), "proposal1 shouldn't be in the attention list"
             end
           end
-        end
 
-        context "And the talk is then updated by the proposer" do
-          setup do
-            Timecop.travel 10.minutes.from_now
-
-            @proposal1.description = "I will, of course, be covering what you need to look out for when using this gem on JRuby."
-            @proposal1.save!
+          context "and I have made suggestions for other talks with recent activity" do
+            setup do
+              FactoryGirl.create(:suggestion, :author => @me, :proposal => @proposal2)
+              Timecop.travel 10.minutes
+              @proposal2.update_attributes! :description => 'Now more interesting than before.'
+              visit '/dashboard'
+            end
 
-            Timecop.travel 1.minute.from_now
-            visit '/dashboard'
+            should "not see that talk in my list of proposals with recent activity" do
+              within('#things-have-changed') do
+                assert !page.has_content?(@proposal1.title), "proposal1 shouldn't be in the changed list"
+              end
+            end
           end
 
-          should "see that talk in my list of proposals with recent activity" do
-            within('#things-have-changed') do
-              assert page.has_content?(@proposal1.title), "proposal1 should be in the changed list"
+          context "And the talk is then updated by the proposer" do
+            setup do
+              Timecop.travel 10.minutes.from_now
+
+              @proposal1.description = "I will, of course, be covering what you need to look out for when using this gem on JRuby."
+              @proposal1.save!
+
+              Timecop.travel 1.minute.from_now
+              visit '/dashboard'
+            end
+
+            should "see that talk in my list of proposals with recent activity" do
+              within('#things-have-changed') do
+                assert page.has_content?(@proposal1.title), "proposal1 should be in the changed list"
+              end
             end
           end
-        end
 
-        context 'And the talk is then withdrawn by the proposer' do
-          setup do
-            Timecop.travel 10.minutes.from_now
-            FactoryGirl.create(:suggestion, :author => @me, :proposal => @proposal2)
-            @proposal1.withdraw!
+          context 'And the talk is then withdrawn by the proposer' do
+            setup do
+              Timecop.travel 10.minutes.from_now
+              FactoryGirl.create(:suggestion, :author => @me, :proposal => @proposal2)
+              @proposal1.withdraw!
 
-            Timecop.travel 10.minutes
-            @proposal2.update_attributes! :description => 'Now more interesting than before.'
+              Timecop.travel 10.minutes
+              @proposal2.update_attributes! :description => 'Now more interesting than before.'
 
-            Timecop.travel 1.minute.from_now
-            visit '/dashboard'
-          end
+              Timecop.travel 1.minute.from_now
+              visit '/dashboard'
+            end
 
-          should 'not see that talk in my list of propopsals with recent activity' do
-            within('#things-have-changed') do
-              assert page.has_no_content?(@proposal1.title), "proposal1 should not be in the changed list"
+            should 'not see that talk in my list of propopsals with recent activity' do
+              within('#things-have-changed') do
+                assert page.has_no_content?(@proposal1.title), "proposal1 should not be in the changed list"
+              end
             end
-          end
 
-          should 'see that talk in my list of withdrawn propopsals' do
-            within('#things-have-ended') do
-              assert page.has_content?(@proposal1.title), "proposal1 should be in the withdrawn list"
+            should 'see that talk in my list of withdrawn propopsals' do
+              within('#things-have-ended') do
+                assert page.has_content?(@proposal1.title), "proposal1 should be in the withdrawn list"
+              end
             end
           end
         end
       end
-
     end
-
   end
 end
\ No newline at end of file