Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDC is not doing fallback to solo-mining #844

Closed
GitGab19 opened this issue Apr 12, 2024 · 4 comments · Fixed by #1055
Closed

JDC is not doing fallback to solo-mining #844

GitGab19 opened this issue Apr 12, 2024 · 4 comments · Fixed by #1055
Assignees
Labels
bug Something isn't working job-declarator-client
Milestone

Comments

@GitGab19
Copy link
Collaborator

During testing, I noticed that sometimes JDC disconnects from upstreams because of some shares refused by the pool (this needs to be investigated better).
In this case, our default config for JDC doesn't contain a second upstream, so JDC should fallback to solo-mining.
But it's not doing that, instead it just hangs there.

@GitGab19 GitGab19 added bug Something isn't working job-declarator-client labels Apr 12, 2024
@pavlenex pavlenex added this to the Milestone 5 milestone Apr 12, 2024
@GitGab19
Copy link
Collaborator Author

GitGab19 commented Apr 13, 2024

For a better context, here's a screenshot I did when I noticed the bug during testing:
Screenshot 2024-04-08 at 15 24 09

@GitGab19
Copy link
Collaborator Author

To reproduce the issue, just try to fake the prev_hash used by the pool to check shares sent by downstream, by changing line 1159 in protocols/v2/roles-logic-sv2/src/channel-logic/channel_factory.rs with this:

//let prev_blockhash = crate::utils::u256_to_block_hash(referenced_job.prev_hash.clone());
let prev_blockhash = crate::utils::u256_to_block_hash([220, 157, 233, 68, 198, 232, 73, 141, 133, 12, 97, 197, 97, 244, 132, 146, 127, 171, 248, 91, 23, 159, 215, 209, 2, 0, 0, 0, 0, 0, 0, 0].into());

@plebhash
Copy link
Collaborator

To reproduce the issue, just try to fake the prev_hash used by the pool to check shares sent by downstream, by changing line 1159 in protocols/v2/roles-logic-sv2/src/channel-logic/channel_factory.rs with this:

//let prev_blockhash = crate::utils::u256_to_block_hash(referenced_job.prev_hash.clone()); let prev_blockhash = crate::utils::u256_to_block_hash([220, 157, 233, 68,

it would be good to reproduce this with MG

@pavlenex pavlenex modified the milestones: 1.0.1, 1.0.2 May 21, 2024
@pavlenex pavlenex assigned lorbax and unassigned GitGab19 Jun 18, 2024
@plebhash plebhash moved this from Todo 📝 to In Progress 🏗️ in SV2 Roadmap 🛣️ Jun 25, 2024
@plebhash
Copy link
Collaborator

plebhash commented Jun 25, 2024

partially solved by #1001

@plebhash plebhash moved this from In Progress 🏗️ to Todo 📝 in SV2 Roadmap 🛣️ Jul 9, 2024
@GitGab19 GitGab19 linked a pull request Jul 16, 2024 that will close this issue
@GitGab19 GitGab19 moved this from Todo 📝 to Blocked ⛔ in SV2 Roadmap 🛣️ Jul 17, 2024
@pavlenex pavlenex moved this from Blocked ⛔ to Ready For Review 🔍 in SV2 Roadmap 🛣️ Jul 30, 2024
@github-project-automation github-project-automation bot moved this from Ready For Review 🔍 to Done ✅ in SV2 Roadmap 🛣️ Aug 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working job-declarator-client
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants