Test Pool role behavior if bad coinbase_output is provided
#1306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1306 +/- ##
==========================================
- Coverage 19.29% 19.14% -0.16%
==========================================
Files 164 166 +2
Lines 10852 10986 +134
==========================================
+ Hits 2094 2103 +9
- Misses 8758 8883 +125
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Bencher Report| Branch | 2024-12-18-pool-bad-cb-config |
| Testbed | sv2 |
🚨 2 Alerts
| Benchmark | Measure Units | View | Benchmark Result (Result Δ%) | Upper Boundary (Limit %) |
|---|---|---|---|---|
| client_sv2_mining_message_submit_standard_serialize_deserialize | L2 Accesses accesses | 📈 plot 🚨 alert (🔔) 🚷 threshold | 97.00 (+17.25%) | 96.68 (100.33%) |
| client_sv2_open_channel_serialize_deserialize | L2 Accesses accesses | 📈 plot 🚨 alert (🔔) 🚷 threshold | 90.00 (+19.73%) | 88.33 (101.89%) |
Click to view all benchmark results
| Benchmark | Estimated Cycles | Benchmark Result estimated cycles (Result Δ%) | Upper Boundary estimated cycles (Limit %) | Instructions | Benchmark Result instructions (Result Δ%) | Upper Boundary instructions (Limit %) | L1 Accesses | Benchmark Result accesses (Result Δ%) | Upper Boundary accesses (Limit %) | L2 Accesses | Benchmark Result accesses (Result Δ%) | Upper Boundary accesses (Limit %) | RAM Accesses | Benchmark Result accesses (Result Δ%) | Upper Boundary accesses (Limit %) |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| client_sv2_handle_message_common | 📈 view plot 🚷 view threshold | 2,163.00 (+2.60%) | 2,225.58 (97.19%) | 📈 view plot 🚷 view threshold | 473.00 (-0.05%) | 488.96 (96.74%) | 📈 view plot 🚷 view threshold | 733.00 (-0.35%) | 758.00 (96.70%) | 📈 view plot 🚷 view threshold | 6.00 (+16.89%) | 12.95 (46.35%) | 📈 view plot 🚷 view threshold | 40.00 (+3.94%) | 41.56 (96.24%) |
| client_sv2_handle_message_mining | 📈 view plot 🚷 view threshold | 8,314.00 (+1.16%) | 8,376.73 (99.25%) | 📈 view plot 🚷 view threshold | 2,137.00 (-0.02%) | 2,142.26 (99.75%) | 📈 view plot 🚷 view threshold | 3,154.00 (-0.18%) | 3,170.59 (99.48%) | 📈 view plot 🚷 view threshold | 38.00 (+7.02%) | 41.71 (91.11%) | 📈 view plot 🚷 view threshold | 142.00 (+1.81%) | 143.83 (98.73%) |
| client_sv2_mining_message_submit_standard | 📈 view plot 🚷 view threshold | 6,379.00 (+1.30%) | 6,440.29 (99.05%) | 📈 view plot 🚷 view threshold | 1,750.00 (-0.04%) | 1,766.91 (99.04%) | 📈 view plot 🚷 view threshold | 2,549.00 (-0.13%) | 2,575.45 (98.97%) | 📈 view plot 🚷 view threshold | 17.00 (-0.23%) | 24.35 (69.82%) | 📈 view plot 🚷 view threshold | 107.00 (+2.33%) | 108.56 (98.56%) |
| client_sv2_mining_message_submit_standard_serialize | 📈 view plot 🚷 view threshold | 14,858.00 (+0.91%) | 14,939.68 (99.45%) | 📈 view plot 🚷 view threshold | 4,694.00 (-0.01%) | 4,710.91 (99.64%) | 📈 view plot 🚷 view threshold | 6,743.00 (-0.21%) | 6,786.11 (99.36%) | 📈 view plot 🚷 view threshold | 55.00 (+23.16%) | 60.08 (91.55%) | 📈 view plot 🚷 view threshold | 224.00 (+1.24%) | 226.59 (98.86%) |
| client_sv2_mining_message_submit_standard_serialize_deserialize | 📈 view plot 🚷 view threshold | 27,880.00 (+1.10%) | 27,984.13 (99.63%) | 📈 view plot 🚷 view threshold | 10,645.00 (+0.42%) | 10,680.59 (99.67%) | 📈 view plot 🚷 view threshold | 15,495.00 (+0.43%) | 15,564.02 (99.56%) | 📈 view plot 🚨 view alert (🔔) 🚷 view threshold | 97.00 (+17.25%) | 96.68 (100.33%) | 📈 view plot 🚷 view threshold | 340.00 (+1.41%) | 342.40 (99.30%) |
| client_sv2_open_channel | 📈 view plot 🚷 view threshold | 4,515.00 (+2.88%) | 4,550.66 (99.22%) | 📈 view plot 🚷 view threshold | 1,461.00 (-0.02%) | 1,476.96 (98.92%) | 📈 view plot 🚷 view threshold | 2,155.00 (-0.25%) | 2,183.67 (98.69%) | 📈 view plot 🚷 view threshold | 10.00 (+21.67%) | 14.26 (70.10%) | 📈 view plot 🚷 view threshold | 66.00 (+5.61%) | 67.08 (98.40%) |
| client_sv2_open_channel_serialize | 📈 view plot 🚷 view threshold | 14,154.00 (+0.96%) | 14,198.97 (99.68%) | 📈 view plot 🚷 view threshold | 5,064.00 (-0.00%) | 5,079.96 (99.69%) | 📈 view plot 🚷 view threshold | 7,314.00 (-0.17%) | 7,351.55 (99.49%) | 📈 view plot 🚷 view threshold | 45.00 (+25.74%) | 46.82 (96.10%) | 📈 view plot 🚷 view threshold | 189.00 (+1.56%) | 191.20 (98.85%) |
| client_sv2_open_channel_serialize_deserialize | 📈 view plot 🚷 view threshold | 22,912.00 (+1.02%) | 22,984.50 (99.68%) | 📈 view plot 🚷 view threshold | 8,040.00 (+0.12%) | 8,052.75 (99.84%) | 📈 view plot 🚷 view threshold | 11,682.00 (-0.00%) | 11,710.59 (99.76%) | 📈 view plot 🚨 view alert (🔔) 🚷 view threshold | 90.00 (+19.73%) | 88.33 (101.89%) | 📈 view plot 🚷 view threshold | 308.00 (+1.49%) | 310.83 (99.09%) |
| client_sv2_setup_connection | 📈 view plot 🚷 view threshold | 4,745.00 (+1.24%) | 4,785.91 (99.15%) | 📈 view plot 🚷 view threshold | 1,502.00 (-0.02%) | 1,517.96 (98.95%) | 📈 view plot 🚷 view threshold | 2,275.00 (-0.14%) | 2,299.50 (98.93%) | 📈 view plot 🚷 view threshold | 11.00 (+14.38%) | 16.16 (68.07%) | 📈 view plot 🚷 view threshold | 69.00 (+2.31%) | 70.06 (98.49%) |
| client_sv2_setup_connection_serialize | 📈 view plot 🚷 view threshold | 16,286.00 (+0.85%) | 16,307.08 (99.87%) | 📈 view plot 🚷 view threshold | 5,963.00 (-0.00%) | 5,978.96 (99.73%) | 📈 view plot 🚷 view threshold | 8,651.00 (-0.15%) | 8,691.55 (99.53%) | 📈 view plot 🚷 view threshold | 50.00 (+24.98%) | 54.20 (92.25%) | 📈 view plot 🚷 view threshold | 211.00 (+1.39%) | 211.93 (99.56%) |
| client_sv2_setup_connection_serialize_deserialize | 📈 view plot 🚷 view threshold | 35,846.00 (+0.75%) | 35,887.25 (99.89%) | 📈 view plot 🚷 view threshold | 14,888.00 (+0.17%) | 14,909.01 (99.86%) | 📈 view plot 🚷 view threshold | 21,866.00 (+0.13%) | 21,907.41 (99.81%) | 📈 view plot 🚷 view threshold | 108.00 (+16.58%) | 113.68 (95.00%) | 📈 view plot 🚷 view threshold | 384.00 (+1.22%) | 385.17 (99.70%) |
|
| Branch | 2024-12-18-pool-bad-cb-config |
| Testbed | sv1 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result nanoseconds (ns) (Result Δ%) | Upper Boundary nanoseconds (ns) (Limit %) |
|---|---|---|---|
| client-submit-serialize | 📈 view plot 🚷 view threshold | 6,531.10 (-1.37%) | 7,053.01 (92.60%) |
| client-submit-serialize-deserialize | 📈 view plot 🚷 view threshold | 7,396.20 (-1.07%) | 8,008.50 (92.35%) |
| client-submit-serialize-deserialize-handle/client-submit-serialize-deserialize-handle | 📈 view plot 🚷 view threshold | 8,005.60 (-1.58%) | 9,367.72 (85.46%) |
| client-sv1-authorize-serialize-deserialize-handle/client-sv1-authorize-serialize-deserialize-handle | 📈 view plot 🚷 view threshold | 863.29 (-0.14%) | 934.34 (92.40%) |
| client-sv1-authorize-serialize-deserialize/client-sv1-authorize-serialize-deserialize | 📈 view plot 🚷 view threshold | 673.39 (+0.18%) | 713.75 (94.35%) |
| client-sv1-authorize-serialize/client-sv1-authorize-serialize | 📈 view plot 🚷 view threshold | 246.93 (-0.83%) | 271.08 (91.09%) |
| client-sv1-get-authorize/client-sv1-get-authorize | 📈 view plot 🚷 view threshold | 157.96 (+0.44%) | 166.36 (94.95%) |
| client-sv1-get-submit | 📈 view plot 🚷 view threshold | 6,295.40 (-1.76%) | 6,995.65 (89.99%) |
| client-sv1-get-subscribe/client-sv1-get-subscribe | 📈 view plot 🚷 view threshold | 281.23 (-0.17%) | 317.33 (88.62%) |
| client-sv1-subscribe-serialize-deserialize-handle/client-sv1-subscribe-serialize-deserialize-handle | 📈 view plot 🚷 view threshold | 729.41 (+0.40%) | 775.23 (94.09%) |
| client-sv1-subscribe-serialize-deserialize/client-sv1-subscribe-serialize-deserialize | 📈 view plot 🚷 view threshold | 602.01 (+2.47%) | 616.83 (97.60%) |
| client-sv1-subscribe-serialize/client-sv1-subscribe-serialize | 📈 view plot 🚷 view threshold | 212.19 (+2.67%) | 224.78 (94.40%) |
|
| Branch | 2024-12-18-pool-bad-cb-config |
| Testbed | sv1 |
Click to view all benchmark results
| Benchmark | Estimated Cycles | Benchmark Result estimated cycles (Result Δ%) | Upper Boundary estimated cycles (Limit %) | Instructions | Benchmark Result instructions (Result Δ%) | Upper Boundary instructions (Limit %) | L1 Accesses | Benchmark Result accesses (Result Δ%) | Upper Boundary accesses (Limit %) | L2 Accesses | Benchmark Result accesses (Result Δ%) | Upper Boundary accesses (Limit %) | RAM Accesses | Benchmark Result accesses (Result Δ%) | Upper Boundary accesses (Limit %) |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| get_authorize | 📈 view plot 🚷 view threshold | 8,418.00 (-0.48%) | 8,678.23 (97.00%) | 📈 view plot 🚷 view threshold | 3,663.00 (-1.92%) | 3,864.50 (94.79%) | 📈 view plot 🚷 view threshold | 5,108.00 (-2.35%) | 5,451.59 (93.70%) | 📈 view plot 🚷 view threshold | 11.00 (+38.58%) | 15.54 (70.77%) | 📈 view plot 🚷 view threshold | 93.00 (+2.11%) | 96.03 (96.84%) |
| get_submit | 📈 view plot 🚷 view threshold | 95,324.00 (-0.07%) | 95,736.20 (99.57%) | 📈 view plot 🚷 view threshold | 59,263.00 (-0.27%) | 59,717.09 (99.24%) | 📈 view plot 🚷 view threshold | 85,074.00 (-0.32%) | 85,833.23 (99.12%) | 📈 view plot 🚷 view threshold | 48.00 (+8.55%) | 59.25 (81.01%) | 📈 view plot 🚷 view threshold | 286.00 (+1.94%) | 290.72 (98.38%) |
| get_subscribe | 📈 view plot 🚷 view threshold | 7,923.00 (-1.07%) | 8,233.22 (96.23%) | 📈 view plot 🚷 view threshold | 2,758.00 (-2.27%) | 2,943.13 (93.71%) | 📈 view plot 🚷 view threshold | 3,833.00 (-2.70%) | 4,143.18 (92.51%) | 📈 view plot 🚷 view threshold | 13.00 (+8.76%) | 19.73 (65.88%) | 📈 view plot 🚷 view threshold | 115.00 (+0.39%) | 117.78 (97.64%) |
| serialize_authorize | 📈 view plot 🚷 view threshold | 12,211.00 (-0.49%) | 12,508.38 (97.62%) | 📈 view plot 🚷 view threshold | 5,240.00 (-1.27%) | 5,429.24 (96.51%) | 📈 view plot 🚷 view threshold | 7,276.00 (-1.61%) | 7,606.86 (95.65%) | 📈 view plot 🚷 view threshold | 14.00 (+43.47%) | 18.42 (75.99%) | 📈 view plot 🚷 view threshold | 139.00 (+0.79%) | 142.18 (97.76%) |
| serialize_deserialize_authorize | 📈 view plot 🚷 view threshold | 24,648.00 (-0.26%) | 25,180.98 (97.88%) | 📈 view plot 🚷 view threshold | 9,786.00 (-0.85%) | 10,028.48 (97.58%) | 📈 view plot 🚷 view threshold | 13,783.00 (-1.05%) | 14,196.22 (97.09%) | 📈 view plot 🚷 view threshold | 38.00 (+7.61%) | 45.34 (83.80%) | 📈 view plot 🚷 view threshold | 305.00 (+0.66%) | 313.42 (97.31%) |
| serialize_deserialize_handle_authorize | 📈 view plot 🚷 view threshold | 30,261.00 (-0.23%) | 30,706.93 (98.55%) | 📈 view plot 🚷 view threshold | 11,989.00 (-0.61%) | 12,199.21 (98.28%) | 📈 view plot 🚷 view threshold | 16,951.00 (-0.74%) | 17,308.59 (97.93%) | 📈 view plot 🚷 view threshold | 58.00 (+4.34%) | 67.04 (86.51%) | 📈 view plot 🚷 view threshold | 372.00 (+0.34%) | 379.27 (98.08%) |
| serialize_deserialize_handle_submit | 📈 view plot 🚷 view threshold | 126,464.00 (-0.01%) | 126,774.00 (99.76%) | 📈 view plot 🚷 view threshold | 73,117.00 (-0.20%) | 73,528.79 (99.44%) | 📈 view plot 🚷 view threshold | 104,759.00 (-0.25%) | 105,496.83 (99.30%) | 📈 view plot 🚷 view threshold | 113.00 (+6.72%) | 124.49 (90.77%) | 📈 view plot 🚷 view threshold | 604.00 (+1.07%) | 608.05 (99.33%) |
| serialize_deserialize_handle_subscribe | 📈 view plot 🚷 view threshold | 27,871.00 (-0.11%) | 28,435.97 (98.01%) | 📈 view plot 🚷 view threshold | 9,577.00 (-0.65%) | 9,756.81 (98.16%) | 📈 view plot 🚷 view threshold | 13,516.00 (-0.83%) | 13,832.10 (97.71%) | 📈 view plot 🚷 view threshold | 71.00 (+11.07%) | 76.76 (92.49%) | 📈 view plot 🚷 view threshold | 400.00 (+0.34%) | 411.68 (97.16%) |
| serialize_deserialize_submit | 📈 view plot 🚷 view threshold | 115,181.00 (-0.06%) | 115,724.96 (99.53%) | 📈 view plot 🚷 view threshold | 67,894.00 (-0.27%) | 68,423.14 (99.23%) | 📈 view plot 🚷 view threshold | 97,356.00 (-0.33%) | 98,291.56 (99.05%) | 📈 view plot 🚷 view threshold | 72.00 (+12.64%) | 84.53 (85.18%) | 📈 view plot 🚷 view threshold | 499.00 (+1.26%) | 501.74 (99.45%) |
| serialize_deserialize_subscribe | 📈 view plot 🚷 view threshold | 23,268.00 (-0.20%) | 23,849.13 (97.56%) | 📈 view plot 🚷 view threshold | 8,129.00 (-0.79%) | 8,313.77 (97.78%) | 📈 view plot 🚷 view threshold | 11,418.00 (-1.03%) | 11,741.47 (97.25%) | 📈 view plot 🚷 view threshold | 46.00 (+20.53%) | 49.23 (93.44%) | 📈 view plot 🚷 view threshold | 332.00 (+0.28%) | 343.59 (96.63%) |
| serialize_submit | 📈 view plot 🚷 view threshold | 99,785.00 (-0.03%) | 100,178.34 (99.61%) | 📈 view plot 🚷 view threshold | 61,325.00 (-0.24%) | 61,743.52 (99.32%) | 📈 view plot 🚷 view threshold | 87,930.00 (-0.30%) | 88,661.31 (99.18%) | 📈 view plot 🚷 view threshold | 54.00 (+14.61%) | 65.13 (82.91%) | 📈 view plot 🚷 view threshold | 331.00 (+1.74%) | 335.97 (98.52%) |
| serialize_subscribe | 📈 view plot 🚷 view threshold | 11,414.00 (+0.06%) | 11,611.40 (98.30%) | 📈 view plot 🚷 view threshold | 4,111.00 (-1.43%) | 4,283.46 (95.97%) | 📈 view plot 🚷 view threshold | 5,689.00 (-1.86%) | 5,996.37 (94.87%) | 📈 view plot 🚷 view threshold | 18.00 (+35.77%) | 22.56 (79.78%) | 📈 view plot 🚷 view threshold | 161.00 (+1.65%) | 163.70 (98.35%) |
|
Should I add a commit to remove the equivalent MG test? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1305