Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration test test_sniffer_interrupter() should be under /roles/tests-integration/tests/common module #1296

Open
GitGab19 opened this issue Dec 13, 2024 · 1 comment · May be fixed by #1297

Comments

@GitGab19
Copy link
Collaborator

We currently have a test called test_sniffer_interrupter() in /roles/tests-integration/tests/pool_integration.rs (here).

The test is testing the sniffer functionality, so it should live under /roles/tests-integration/tests/common module.

@jbesraa
Copy link
Contributor

jbesraa commented Dec 13, 2024

I think the test will run with each different file if we move it to tests/common, i.e, now we have pool_integration.rs and translator_integration.rs, if we move the test to tests/common it will run twice

@jbesraa jbesraa linked a pull request Dec 13, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants