Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need Rust docs on protocols::v2::subprotocols #1201

Closed
3 of 4 tasks
GitGab19 opened this issue Oct 11, 2024 · 1 comment
Closed
3 of 4 tasks

Need Rust docs on protocols::v2::subprotocols #1201

GitGab19 opened this issue Oct 11, 2024 · 1 comment
Assignees
Labels
documentation Improvements or additions to documentation protocols Lowest level protocol logic
Milestone

Comments

@GitGab19
Copy link
Collaborator

GitGab19 commented Oct 11, 2024

Background

Currently, the protocols::v2::subprotocols has already been documented, but it's worth a look to see where to improve it. Since it contains 4 different crates, this issue is the tracker one, and more specific ones are going to be grouped here.

Note: While this issue addresses the need for doc comments, it will also serve as a means to identify code debt that needs to be cleaned up and addressed in future issues.

Solution

Navigate through each crate in protocols::v2::subprotocols and add:

  • Rust Docs comments (following the formatting structure in this on-going discussion), to be displayed in docs.rs
  • a descriptive README.md file to be displayed in crates.io

While this work is being performed, specific code debt should be looked for and recorded to turn into future issues

Task list

@GitGab19 GitGab19 added documentation Improvements or additions to documentation protocols Lowest level protocol logic labels Oct 11, 2024
@GitGab19 GitGab19 added this to the 1.2.0 milestone Oct 11, 2024
@GitGab19 GitGab19 changed the title Need Rust docs on protocols::v2::subprotocols Need Rust docs on protocols::v2::subprotocols Oct 11, 2024
@plebhash plebhash assigned GitGab19 and jbesraa and unassigned GitGab19 Oct 11, 2024
@GitGab19 GitGab19 moved this from Todo 📝 to In Progress 🏗️ in SV2 Roadmap 🛣️ Dec 9, 2024
@github-project-automation github-project-automation bot moved this from In Progress 🏗️ to Done ✅ in SV2 Roadmap 🛣️ Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation protocols Lowest level protocol logic
Projects
Status: Done ✅
Development

No branches or pull requests

3 participants