Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom logger #1200

Open
plebhash opened this issue Oct 10, 2024 · 2 comments
Open

custom logger #1200

plebhash opened this issue Oct 10, 2024 · 2 comments
Labels
protocols Lowest level protocol logic

Comments

@plebhash
Copy link
Collaborator

background

protocols crates should use as little external dependencies as possible.

problem

currently, the following crates use tracing as an external dependency:

solution

write a custom logger to replace tracing

reference from rust-lightning: https://github.com/lightningdevkit/rust-lightning/blob/f94bf9861289ce6a75fd7d5856d736a2f966a619/lightning/src/util/logger.rs#L165

@plebhash plebhash added the protocols Lowest level protocol logic label Oct 10, 2024
@Fi3
Copy link
Collaborator

Fi3 commented Oct 11, 2024

tracing is kinda of the standard for logging, every project that will use the library will very likely expect to have log reported by tracing, is also audited by google. https://github.com/google/rust-crate-audits/blob/main/manual-sources/google3-audits.toml#L1383

I don't think that we should remove it, if there is a way to do that without disrupting the user experience could make sense. If not no.

@Shourya742
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
protocols Lowest level protocol logic
Projects
None yet
Development

No branches or pull requests

3 participants